-
Notifications
You must be signed in to change notification settings - Fork 5.5k
router: implement new regex_rewrite route action #10050
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 13 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
8d72dd3
Implement new regex_rewrite route action.
cc5d676
Bump the "next-free-field" value for RouteAction
b7e83ba
Correct link for regex_rewrite
df75906
Hopefully fix documentation formatting errors
7e09740
Address pedantic spelling complaints
6f7367a
Move the RegexRewrite message in the proto files to conform with chec…
02f843f
Update documentation as requested.
e5bab50
Raise an exception if both prefix_rewrite and regex_rewrite are used.
8c7984e
Update a comment that still mentioned a precedence
5626c24
Merge branch 'master' into regex-rewrite
68cf320
Address review comments
9347972
Merge branch 'master' into regex-rewrite
6978103
Remove oneof_promotion annotations from v3 protos, as tooling is not …
bdaef86
Merge branch 'master' into regex-rewrite
ba5ad9f
Make the RegexRewrite api message a general type called RegexMatchAnd…
4eed676
Use the existing regex.proto file for the RegexMatchAndSubstitute mes…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
57 changes: 56 additions & 1 deletion
57
generated_api_shadow/envoy/api/v2/route/route_components.proto
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
60 changes: 59 additions & 1 deletion
60
generated_api_shadow/envoy/config/route/v3/route_components.proto
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we extract this type into
envoy.type? I think we're likely to reuse it in other places?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking through this again, yes, I think it makes sense to move this to a matcher. How about
RegexMatchAndSubstituteor something like that?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking through this again, yes, I think it makes sense to move this to a matcher. How about
RegexMatchAndSubstituteor something like that?Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I merged from the
masterbranch again to resolve some conflicts and made the requested change, renaming theRegexRewritemessage toRegexMatchAndSubstituteand making it a general type so it can potentially be re-used elsewhere.