Skip to content

Commit

Permalink
tcp tunneling: fix integration test flake
Browse files Browse the repository at this point in the history
We need to wait for all listeners to be up.

Fixes #12253

Signed-off-by: Matt Klein <[email protected]>
  • Loading branch information
mattklein123 committed Jul 24, 2020
1 parent da58cfc commit 5ad5ab3
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion test/integration/integration.cc
Original file line number Diff line number Diff line change
Expand Up @@ -490,7 +490,9 @@ void BaseIntegrationTest::createGeneratedApiTestServer(
const char* rejected = "listener_manager.lds.update_rejected";
for (Stats::CounterSharedPtr success_counter = test_server_->counter(success),
rejected_counter = test_server_->counter(rejected);
(success_counter == nullptr || success_counter->value() < concurrency_) &&
(success_counter == nullptr ||
success_counter->value() <
concurrency_ * config_helper_.bootstrap().static_resources().listeners_size()) &&
(!allow_lds_rejection || rejected_counter == nullptr || rejected_counter->value() == 0);
success_counter = test_server_->counter(success),
rejected_counter = test_server_->counter(rejected)) {
Expand Down

0 comments on commit 5ad5ab3

Please sign in to comment.