Skip to content
This repository was archived by the owner on Dec 16, 2020. It is now read-only.

fixes to filter state getters/setters#486

Merged
kyessenov merged 2 commits intoenvoyproxy:masterfrom
kyessenov:fix_life_span
Apr 20, 2020
Merged

fixes to filter state getters/setters#486
kyessenov merged 2 commits intoenvoyproxy:masterfrom
kyessenov:fix_life_span

Conversation

@kyessenov
Copy link
Contributor

@kyessenov kyessenov commented Apr 20, 2020

Signed-off-by: Kuat Yessenov kuat@google.com

  • add nullptr check for upstream filter state
  • retrieve flatbuffer as bytes if no field is traversed
  • propagate wasm life span to setData
  • make data always mutable to avoid runtime errors

Signed-off-by: Kuat Yessenov <kuat@google.com>
@kyessenov
Copy link
Contributor Author

Need more patches. Hold on yet.

Signed-off-by: Kuat Yessenov <kuat@google.com>
@kyessenov kyessenov changed the title patch setData life_span_ fixes to filter state getters/setters Apr 20, 2020
@kyessenov kyessenov merged commit f80bba6 into envoyproxy:master Apr 20, 2020
kyessenov added a commit to istio/envoy that referenced this pull request Apr 20, 2020
Signed-off-by: Kuat Yessenov <kuat@google.com>
howardjohn pushed a commit to istio/envoy that referenced this pull request Apr 21, 2020
Signed-off-by: Kuat Yessenov <kuat@google.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants