This repository was archived by the owner on Dec 16, 2020. It is now read-only.
Merged
Conversation
This was under filter/http/common/aws for historical reasons, so moving it to source/extensions/common/aws where it should live. Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
Signed-off-by: Derek Argueta <dereka@pinterest.com>
Signed-off-by: tianqian.zyf <tianqian.zyf@alibaba-inc.com>
Signed-off-by: Yan Avlasov <yavlasov@google.com>
…view is an alias of std::string_view in some C++17 environments and argument dependent lookup fails to find functions in absl namespace. (#9931) Signed-off-by: Yan Avlasov <yavlasov@google.com>
Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
This is part 1 in a set of changes to refactor the HTTP codecs so they can emit typed request headers, request trailers, response headers, and response trailers. This will help clean up various interface inconsistencies as well as unlock a greater variety of header map improvements. Signed-off-by: Matt Klein <mklein@lyft.com>
Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
Signed-off-by: Yuval Kohavi <yuval.kohavi@gmail.com>
Description: This PR adds support of generic secret type in secret manager. The goal is to enable filters to access generic secret. Risk Level: Medium Testing: Unit test, Integration test Docs Changes: Changed Release Notes: Changed Signed-off-by: bennettdong <xiangfeid@gmail.com>
Adds a force load factory declaration so that this filter can be force-loaded by Envoy Mobile. Risk Level: Low Testing: Done locally, and CI Docs Changes: None Release Notes: None Signed-off-by: Michael Rebello <me@michaelrebello.com>
Originally discussed and approved in: https://bit.ly/envoy-stable-releases Fixes #7915. Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Description: this PR adds logic to the DnsResolverImpl to destroy and re-initialize its c-ares channel under certain circumstances. A better option would require work in c-ares c-ares/c-ares#301. Risk Level: med changes in low-level DNS resolution. Testing: unit tests Fixes #4543 Signed-off-by: Jose Nino <jnino@lyft.com>
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Modifies the well-known-names of the built-in access loggers to use the same name as the extension build system. Risk Level: low, previous name is still accepted Testing: existing tests Docs Changes: updated names Release Notes: updated Deprecated: old names are logged as deprecated Signed-off-by: Stephan Zuercher <zuercher@gmail.com>
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
This allows stats to work if the server is not yet listening. As part of this change also clean up some UDP tests to use a common synchronous helper. Fixes envoyproxy/envoy#8911 Signed-off-by: Matt Klein <mklein@lyft.com>
Signed-off-by: Pengyuan Bian <bianpengyuan@google.com>
* Allow -l warn to configure log level on startup, and protect against invalid values for log level. Signed-off-by: Erica Manno <erica.manno@gmail.com>
Signed-off-by: Dan Zhang <danzh@google.com>
…nks (#9947) The min_concurrency setting dicated the concurrency limit when in a min_rtt calculation window. However, if the gradient caused the concurrency limit to shrink, it was possible for the limit to drop below this configured minimum. This patch fixes this behavior so that the calculated concurrency limit is always >= the configured minimum. In addition, a minor change to the stat indicating whether the min_rtt calculation window is active. When active, the stat was being set to the concurrency limit; however, according to the documentation this should be either 0 or 1. This patch also fixes this behavior. Signed-off-by: Tony Allen <tony@allen.gg>
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Description: force link the v2 proto for metrics service config. Needed in some linking scenarios. Related to #9639. Risk Level: low Testing: on an iOS build of Envoy Mobile. Signed-off-by: Jose Nino <jnino@lyft.com>
Signed-off-by: William A Rowe Jr <wrowe@pivotal.io> Signed-off-by: Yechiel Kalmenson <ykalmenson@pivotal.io> Signed-off-by: Sunjay Bhatia <sbhatia@pivotal.io>
…() (#9944) Signed-off-by: Dan Zhang <danzh@google.com>
Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
Signed-off-by: Todd Greer <tgreer@google.com>
…… (#9882) Signed-off-by: Gary Brown <gary@brownuk.com>
gargnupur
requested review from
PiotrSikora,
alyssawilk,
dio,
htuch,
jmarantz,
jplevyak,
lizan,
mattklein123,
snowp and
zuercher
as code owners
This is "the big one" in the header map refactor. This commit uses typed headers all the way through the encoding path and thus requires an interface change in HTTP filters. Although the lines of code changed in this PR is huge, the regression risk is low as this change is almost entirely an extremely tedious fixup PR to use the correct types. Quite a few filter tests needed fixing as they were using the wrong header type for trailers, etc. Signed-off-by: Matt Klein <mklein@lyft.com>
Signed-off-by: Jimmy Chen <yinjie@google.com>
Signed-off-by: Lisa Lu <lisalu@lyft.com>
Signed-off-by: Yan Avlasov <yavlasov@google.com>
Description: last iteration in reorg of tools dir (see #9568). In this PR: - debugging files are grouped under `tools/debugging`; - protoxform test files are moved to `tools/protoxform`; - proto format files are grouped under `tools/proto_format`. Risk Level: low Testing: manual Docs Changes: N/A Release Notes: N/A Signed-off-by: Erica Manno <erica.manno@gmail.com>
gargnupur
force-pushed
the
nup_update3
branch
from
163fb0e to
cf29477
Compare
Signed-off-by: gargnupur <gargnupur@google.com>
Signed-off-by: gargnupur <gargnupur@google.com>
PiotrSikora
approved these changes
Feb 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Merge remote-tracking branch 'envoy-remote/master' into nup_update3
Description:Merge remote envoy
Risk Level:
Testing:
Docs Changes:
Release Notes:
[Optional Fixes #Issue]
[Optional Deprecated:]