This repository was archived by the owner on Dec 16, 2020. It is now read-only.
Update GrpcService to add StsService.#411
Merged
jplevyak merged 1 commit intoenvoyproxy:masterfrom Feb 14, 2020
Merged
Conversation
Signed-off-by: John Plevyak <jplevyak@gmail.com>
Contributor
Author
|
Once this is in it should be backported... .to 1.5 + 1.4 ? |
Contributor
|
@duderino @howardjohn FYI |
Contributor
|
Definitely 1.5. Desirable in 1.4. |
PiotrSikora
approved these changes
Feb 14, 2020
Contributor
|
Why 1.4? 1.4 is for patches not features. We violate that sometimes, but it needs a good reason |
Contributor
|
So there are two protos for GrpcService. We updated one in 1.4 with StsService field but not the other. Wasm ABI converts the two protos at runtime, so it's losing the field on the ABI. |
Contributor
|
@kyessenov, @howardjohn and I chatted and we're ok with the change itself. the concern is more about timing. If it had arrived a day earlier we could have gotten it into 1.4.5. I think we can backport this to 1.4, but I don't think we want to do a special release just for this |
kyessenov
pushed a commit
to kyessenov/envoy-wasm
that referenced
this pull request
Feb 18, 2020
Signed-off-by: John Plevyak <jplevyak@gmail.com>
bianpengyuan
pushed a commit
to bianpengyuan/envoy-wasm
that referenced
this pull request
Feb 21, 2020
Signed-off-by: John Plevyak <jplevyak@gmail.com>
bianpengyuan
pushed a commit
to bianpengyuan/envoy-wasm
that referenced
this pull request
Feb 21, 2020
Update GrpcService to add StsService. (envoyproxy#411)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: John Plevyak jplevyak@gmail.com