This repository was archived by the owner on Dec 16, 2020. It is now read-only.
Cache and share the base Wasm#387
Merged
jplevyak merged 5 commits intoenvoyproxy:masterfrom Jan 31, 2020
Merged
Conversation
find the base Wasm and thread local Wasm. Signed-off-by: John Plevyak <jplevyak@gmail.com>
Signed-off-by: John Plevyak <jplevyak@gmail.com>
PiotrSikora
reviewed
Jan 31, 2020
| } | ||
| } | ||
| } | ||
| // Drop the lock so that the the expensive Wasm creation is not under the lock. |
Contributor
There was a problem hiding this comment.
But then, we will pay the price for creating many expensive Wasm VMs at the same time, and discarding those that lost the race anyway, won't we?
Contributor
Author
There was a problem hiding this comment.
Given that this is going to run on the main thread currently there are not going to be any races. So, perhaps it isn't worth dropping the lock. Removed. PTAL
Signed-off-by: John Plevyak <jplevyak@gmail.com>
PiotrSikora
reviewed
Jan 31, 2020
Signed-off-by: John Plevyak <jplevyak@gmail.com>
Signed-off-by: John Plevyak <jplevyak@gmail.com>
PiotrSikora
reviewed
Jan 31, 2020
PiotrSikora
approved these changes
Jan 31, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cache and share the base Wasm. Use the new definition of Wasm Key to find the base Wasm and thread local Wasm.