This repository was archived by the owner on Dec 16, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 85
use foreign_cc to build wee8 #152
Closed
Closed
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,8 +3,9 @@ | |
| # 3. Fix for VMs with overlapping lifetimes (https://crrev.com/c/1698387). | ||
| # 4. Fix linking with unbundled toolchain on macOS. | ||
| # 5. Increase VSZ limit to 4TiB (allows us to start up to 370 VMs). | ||
| --- a/wee8/build/toolchain/gcc_toolchain.gni | ||
| +++ b/wee8/build/toolchain/gcc_toolchain.gni | ||
| # 6. Remove Bazel added -fuse-ld=gold if gn chose -fuse-ld=lld | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please add: |
||
| --- a/build/toolchain/gcc_toolchain.gni | ||
| +++ b/build/toolchain/gcc_toolchain.gni | ||
| @@ -355,6 +355,8 @@ template("gcc_toolchain") { | ||
| # AIX does not support either -D (deterministic output) or response | ||
| # files. | ||
|
|
@@ -23,8 +24,8 @@ | |
| # the "--start-group .. --end-group" feature isn't available on the aix ld. | ||
| start_group_flag = "-Wl,--start-group" | ||
| end_group_flag = "-Wl,--end-group " | ||
| --- a/wee8/src/wasm/c-api.cc | ||
| +++ b/wee8/src/wasm/c-api.cc | ||
| --- a/src/wasm/c-api.cc | ||
| +++ b/src/wasm/c-api.cc | ||
| @@ -633,7 +633,7 @@ auto seal(const typename implement<C>::type* x) -> const C* { | ||
| return reinterpret_cast<const C*>(x); | ||
| } | ||
|
|
@@ -70,8 +71,8 @@ | |
| store->context()->Enter(); | ||
| isolate->SetData(0, store.get()); | ||
|
|
||
| --- a/wee8/src/wasm/wasm-memory.cc | ||
| +++ b/wee8/src/wasm/wasm-memory.cc | ||
| --- a/src/wasm/wasm-memory.cc | ||
| +++ b/src/wasm/wasm-memory.cc | ||
| @@ -139,7 +139,7 @@ void* TryAllocateBackingStore(WasmMemoryTracker* memory_tracker, Heap* heap, | ||
| // address space limits needs to be smaller. | ||
| constexpr size_t kAddressSpaceLimit = 0x8000000000L; // 512 GiB | ||
|
|
@@ -81,8 +82,8 @@ | |
| #else | ||
| constexpr size_t kAddressSpaceLimit = 0xC0000000; // 3 GiB | ||
| #endif | ||
| --- a/wee8/third_party/wasm-api/wasm.hh | ||
| +++ b/wee8/third_party/wasm-api/wasm.hh | ||
| --- a/third_party/wasm-api/wasm.hh | ||
| +++ b/third_party/wasm-api/wasm.hh | ||
| @@ -111,7 +111,7 @@ class vec { | ||
| size_t size_; | ||
| std::unique_ptr<T[]> data_; | ||
|
|
@@ -92,3 +93,28 @@ | |
| void make_data(); | ||
| void free_data(); | ||
| #else | ||
|
|
||
|
|
||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nit: extra empty lines between patches. |
||
| --- a/build/config/compiler/BUILD.gn | ||
| +++ b/build/config/compiler/BUILD.gn | ||
| @@ -233,7 +233,6 @@ config("compiler") { | ||
| ":clang_revision", | ||
| ":compiler_cpu_abi", | ||
| ":compiler_codegen", | ||
| - ":compiler_deterministic", | ||
| ] | ||
|
|
||
| # In general, Windows is totally different, but all the other builds share | ||
| --- a/build/toolchain/wrapper_utils.py | ||
| +++ b/build/toolchain/wrapper_utils.py | ||
| @@ -63,6 +63,10 @@ def RunLinkWithOptionalMapFile(command, env=None, map_file=None): | ||
| Returns: | ||
| The exit code of running |command|. | ||
| """ | ||
| + | ||
| + if "-fuse-ld=lld" in command and "-fuse-ld=gold" in command: | ||
| + command.remove("-fuse-ld=gold") | ||
| + | ||
| tmp_map_path = None | ||
| if map_file and map_file.endswith('.gz'): | ||
| tmp_map_path = map_file + '.tmp' | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: sort alphabetically.