update envoy: update interfaces, and fix broken macos ci#879
Merged
Conversation
Signed-off-by: Jose Nino <jnino@lyft.com>
keith
previously approved these changes
Jun 4, 2020
rebello95
previously approved these changes
Jun 4, 2020
buildbreaker
previously approved these changes
Jun 4, 2020
junr03
dismissed stale reviews from buildbreaker, rebello95, and keith
via
c48934c
added 5 commits
June 4, 2020 16:22
Signed-off-by: Jose Nino <jnino@lyft.com>
Signed-off-by: Jose Nino <jnino@lyft.com>
This reverts commit 748d76b. Signed-off-by: Jose Nino <jnino@lyft.com>
Signed-off-by: Jose Nino <jnino@lyft.com>
Signed-off-by: Jose Nino <jnino@lyft.com>
junr03
commented
Jun 5, 2020
| Envoy::Extensions::TransportSockets::Tls::forceRegisterUpstreamSslSocketFactory(); | ||
| Envoy::Upstream::forceRegisterLogicalDnsClusterFactory(); | ||
|
|
||
| // TODO: add a "force initialize" function to the upstream code, or clean up the upstream code |
rebello95
approved these changes
Jun 5, 2020
Comment on lines
+3
to
+4
| licenses(["notice"]) # Apache 2 | ||
|
|
Contributor
There was a problem hiding this comment.
Are these all deliberate?
buildbreaker
approved these changes
Jun 5, 2020
|
|
Member
Author
|
looks like the android linux_dist job ran out of time https://github.com/lyft/envoy-mobile/pull/879/checks?check_run_id=743616566 going to merge this and check what is up with the time limit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: this submodule update brings in an updated macOS ci setup script that correctly install bazelisk. envoyproxy/envoy#11444
Risk Level: low
Testing: CI
Signed-off-by: Jose Nino jnino@lyft.com