Conversation
rebello95
left a comment
rebello95
left a comment
There was a problem hiding this comment.
LGTM, one comment. If you could also update the description to include a bit more direct context from the PR regarding their differences that might be helpful for future reference
keith
force-pushed
the
ks/bazel-update-swift_static_framework-to-use-swiftinterfaces
branch
from
442da75 to
9bc0078
Compare
|
This pull request has been automatically marked as stale because it has not had activity in the last 7 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
keith
force-pushed
the
ks/bazel-update-swift_static_framework-to-use-swiftinterfaces
branch
from
a96c5f2 to
8e0a0c6
Compare
|
This still includes the swiftmodule file in the framework because of this issue, bazelbuild/rules_apple#753 this way people can continue to use it as before for now, but folks who apply this patch can use the swiftinterface instead. |
keith
force-pushed
the
ks/bazel-update-swift_static_framework-to-use-swiftinterfaces
branch
2 times, most recently
from
226f70c to
41cece6
Compare
|
This pull request has been automatically marked as stale because it has not had activity in the last 7 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
This is an in between to #797 which starts building the archive with swiftinterface files, but does it with our existing swift_static_framework rule because of issues linked on that PR. Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>
Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>
Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>
keith
force-pushed
the
ks/bazel-update-swift_static_framework-to-use-swiftinterfaces
branch
from
41cece6 to
0d88782
Compare
|
This currently contains both the swiftinterface and the swiftmodule file, once bazelbuild/rules_apple#753 is fixed we can remove the swiftmodule file |
| @@ -1,4 +1,5 @@ | |||
| @testable import Envoy | |||
| import EnvoyEngine | |||
There was a problem hiding this comment.
Out of curiosity, any reason not to use @_implementationOnly here for consistency?
There was a problem hiding this comment.
It doesn't really matter for tests since no one consumes their output swiftmodule, and the annoyance is that if you do it once in a single target you have to do it for all imports, so then everyone has to know about it.
keith
deleted the
ks/bazel-update-swift_static_framework-to-use-swiftinterfaces
branch
2 participants
This is an in between to #797
which starts building the archive with swiftinterface files, but does
it with our existing swift_static_framework rule because of issues
linked on that PR.
Signed-off-by: Keith Smiley keithbsmiley@gmail.com