Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions library/common/http/dispatcher.cc
Original file line number Diff line number Diff line change
Expand Up @@ -462,8 +462,8 @@ Dispatcher::DirectStreamSharedPtr Dispatcher::getStream(envoy_stream_t stream) {
}

void Dispatcher::cleanup(envoy_stream_t stream_handle) {
ASSERT(TS_UNCHECKED_READ(event_dispatcher_)->isThreadSafe(),
"stream cleanup must be performed on the event_dispatcher_'s thread.");
RELEASE_ASSERT(TS_UNCHECKED_READ(event_dispatcher_)->isThreadSafe(),
"stream cleanup must be performed on the event_dispatcher_'s thread.");
Dispatcher::DirectStreamSharedPtr direct_stream = getStream(stream_handle);
RELEASE_ASSERT(direct_stream,
"cleanup is a private method that is only called with stream ids that exist");
Expand Down
8 changes: 5 additions & 3 deletions library/common/http/dispatcher.h
Original file line number Diff line number Diff line change
Expand Up @@ -113,8 +113,10 @@ class Dispatcher : public Logger::Loggable<Logger::Id::http> {
Stream& getStream() override;
Http1StreamEncoderOptionsOptRef http1StreamEncoderOptions() override { return absl::nullopt; }
// TODO: implement
void encode100ContinueHeaders(const ResponseHeaderMap&) override {}
void encodeMetadata(const MetadataMapVector&) override {}
void encode100ContinueHeaders(const ResponseHeaderMap&) override {
NOT_IMPLEMENTED_GCOVR_EXCL_LINE;
}
void encodeMetadata(const MetadataMapVector&) override { NOT_IMPLEMENTED_GCOVR_EXCL_LINE; }

private:
DirectStream& direct_stream_;
Expand Down Expand Up @@ -145,7 +147,7 @@ class Dispatcher : public Logger::Loggable<Logger::Id::http> {
return parent_.address_;
}
// TODO: stream watermark control.
void readDisable(bool) override {}
void readDisable(bool) override { NOT_IMPLEMENTED_GCOVR_EXCL_LINE; }
uint32_t bufferLimit() override { return 65000; }

void closeLocal(bool end_stream);
Expand Down
2 changes: 1 addition & 1 deletion library/common/network/synthetic_address_impl.h
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ class SyntheticAddressImpl : public Instance {

Type type() const {
// TODO(junr03): consider adding another type of address.
return Address::Type::Ip;
return Type::Ip;
}

private:
Expand Down
Loading