Conversation
Signed-off-by: Jose Nino <jnino@lyft.com>
Member
Author
|
Needs envoyproxy/envoy#10674 to merge first. Also note that the coverage report is not being published yet. This is tracked in #787 |
added 9 commits
April 6, 2020 18:57
Signed-off-by: Jose Nino <jnino@lyft.com>
Signed-off-by: Jose Nino <jnino@lyft.com>
Signed-off-by: Jose Nino <jnino@lyft.com>
Signed-off-by: Jose Nino <jnino@lyft.com>
Member
Author
|
As expected. Now we should pass when I merge #792 |
added 2 commits
April 8, 2020 13:48
Signed-off-by: Jose Nino <jnino@lyft.com>
rebello95
approved these changes
Apr 9, 2020
buildbreaker
approved these changes
Apr 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: add script for coverage report generation and CI test for coverage check.
Risk Level: low
Testing: locally generated report, and new CI check
Fixes #786
Signed-off-by: Jose Nino jnino@lyft.com