Conversation
Signed-off-by: Jose Nino <jnino@lyft.com>
buildbreaker
previously approved these changes
Feb 12, 2020
Signed-off-by: Jose Nino <jnino@lyft.com>
junr03
changed the title
Member
Author
|
@buildbreaker I actually noticed a couple more places to clean up. lmk what you think |
rebello95
reviewed
Feb 12, 2020
buildbreaker
previously approved these changes
Feb 12, 2020
rebello95
reviewed
Feb 12, 2020
rebello95
approved these changes
Feb 13, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: envoyproxy/envoy#9767 introduced the bazel option and #663 brought it into envoy mobile. This PR changes the bazel config for android to turn on the logger by default when building on android. It also updates a couple other stale flags and docs.
Risk Level: low
Testing: tested locally and saw logs
Fixes #34
Signed-off-by: Jose Nino jnino@lyft.com