ci: deploy/upload CocoaPods artifact on master commits#621
Merged
Conversation
Signed-off-by: Michael Rebello <me@michaelrebello.com>
Signed-off-by: Michael Rebello <me@michaelrebello.com>
Signed-off-by: Michael Rebello <me@michaelrebello.com>
Signed-off-by: Michael Rebello <me@michaelrebello.com>
Contributor
Author
This reverts commit 2f4f5fc. Signed-off-by: Michael Rebello <me@michaelrebello.com>
keith
approved these changes
Jan 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a job (run on merges to master) to upload an artifact that can be consumed by CocoaPods. This process requires the following steps (outlined in #577):
envoy_ios_framework.zipenvoy_ios_cocoapodsenvoy_ios_cocoapods/Envoy.framework/Swift/Empty.swift. This forces CocoaPods to link Swift libraries as necessary. We worked around this in Bazel similarly in the past hereLICENSEfile and placing it atenvoy_ios_cocoapods/LICENSEenvoy_ios_cocoapodsand uploadingenvoy_ios_cocoapods.zipTested and validated that the artifact was successfully uploaded in this job.
Resolves #578.