Skip to content

ios: fix podspec for v0.2.0 support #577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rebello95 merged 5 commits into from
Nov 8, 2019
Merged

ios: fix podspec for v0.2.0 support #577

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
84f6d3e
wip
rebello95 Nov 5, 2019
40d1ef9
Update EnvoyMobile.podspec
rebello95 Nov 5, 2019
a367409
Update EnvoyMobile.podspec
rebello95 Nov 5, 2019
cacd10e
stop aligning entries
rebello95 Nov 5, 2019
2ecd131
CR
rebello95 Nov 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 15 additions & 11 deletions EnvoyMobile.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,17 @@
Pod::Spec.new do |s|
s.name = 'EnvoyMobile'
s.version = '0.2.0'
s.author = 'Lyft, Inc.'
s.summary = 'Client networking libraries based on the Envoy project'
s.homepage = 'https://envoy-mobile.github.io'
s.documentation_url = 'https://envoy-mobile.github.io/docs/envoy-mobile/latest/index.html'
s.social_media_url = 'https://twitter.com/EnvoyProxy'
s.license = { :type => 'Apache-2.0', :file => 'LICENSE' }
s.platform = :ios
s.source = { :http => "https://github.com/lyft/envoy-mobile/releases/download/v#{s.version}/envoy_ios_framework.zip" }
s.ios.vendored_frameworks = 'Envoy.framework'
s.name = 'EnvoyMobile'
Comment thread
rebello95 marked this conversation as resolved.
Outdated
s.version = '0.2.0'
s.author = 'Lyft, Inc.'
s.summary = 'Client networking libraries based on the Envoy project'
s.homepage = 'https://envoy-mobile.github.io'
s.documentation_url = 'https://envoy-mobile.github.io/docs/envoy-mobile/latest/index.html'
s.social_media_url = 'https://twitter.com/EnvoyProxy'
s.license = { :type => 'Apache-2.0', :file => 'envoy_ios_cocoapods/LICENSE' }
Comment thread
rebello95 marked this conversation as resolved.
Outdated
s.platform = :ios, '10.0'
s.swift_version = '5.1'
s.libraries = 'resolv.9', 'c++'
s.frameworks = 'SystemConfiguration'
s.source = { :http => "https://github.com/lyft/envoy-mobile/releases/download/v#{s.version}/envoy_ios_cocoapods.zip" }
Comment thread
rebello95 marked this conversation as resolved.
Outdated
s.vendored_frameworks = 'envoy_ios_cocoapods/Envoy.framework'
s.source_files = 'envoy_ios_cocoapods/Envoy.framework/Headers/*.h', 'envoy_ios_cocoapods/Envoy.framework/Swift/*.swift'

@keith keith Nov 5, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You shouldn't need source files since you're vendoring a framework?

@rebello95 rebello95 Nov 5, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without this the framework fails pod spec lint because it's missing libSwiftFoundation, among other Swift libraries. I added some more explanations to the PR description - without this and manually adding a .swift file, the pod doesn't compile. Totally open to better ways to do this

@keith keith Nov 5, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a corresponding CocoaPods issue about this? Seems weird that no one else would have this case

@rebello95 rebello95 Nov 5, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not from what I could tell, but I'm happy to file one. Assuming it's only an issue for mixed Objective-C/Swift libraries?

@keith keith Nov 5, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CP likely doesn't check that either way, but maybe you adding the swift_version was what broke it?

@rebello95 rebello95 Nov 5, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commenting out swift_version and source_files yields the following errors:

   Testing with `xcodebuild`. 
 -> EnvoyMobile (0.2.0)
    - ERROR | [iOS] xcodebuild: Returned an unsuccessful exit code.
    - NOTE  | xcodebuild:  note: Using new build system
    - NOTE  | [iOS] xcodebuild:  note: Planning build
    - NOTE  | [iOS] xcodebuild:  note: Constructing build description
    - NOTE  | [iOS] xcodebuild:  warning: Skipping code signing because the target does not have an Info.plist file and one is not being generated automatically. (in target 'App' from project 'App')
    - NOTE  | xcodebuild:  ld: warning: Could not find or use auto-linked library 'swiftFoundation'
    - NOTE  | xcodebuild:  ld: warning: Could not find or use auto-linked library 'swiftCompatibilityDynamicReplacements'
    - NOTE  | xcodebuild:  ld: warning: Could not find or use auto-linked library 'swiftDarwin'
    - NOTE  | xcodebuild:  ld: warning: Could not find or use auto-linked library 'swiftCoreFoundation'
    - NOTE  | xcodebuild:  ld: warning: Could not find or use auto-linked library 'swiftCore'
    - NOTE  | xcodebuild:  ld: warning: Could not find or use auto-linked library 'swiftCoreGraphics'
    - NOTE  | xcodebuild:  ld: warning: Could not find or use auto-linked library 'swiftObjectiveC'
    - NOTE  | xcodebuild:  ld: warning: Could not find or use auto-linked library 'swiftDispatch'
    - NOTE  | xcodebuild:  ld: warning: Could not find or use auto-linked library 'swiftSwiftOnoneSupport'
    - NOTE  | xcodebuild:  ld: warning: Could not find or use auto-linked library 'swiftCompatibility50'
    - NOTE  | xcodebuild:  clang: error: linker command failed with exit code 1 (use -v to see invocation)

@rebello95 rebello95 Nov 7, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mind taking another look whenever you get a chance @keith?

end