Conversation
Recent changes (namely #498) made it unnecessary for the platform-level clients to start Envoy on newly spawned threads. In fact, these changes actually introduced potential races where consumers of the platform clients could end up calling `send` on engines that hadn't finished starting on these threads. This PR removes the custom threading logic in Swift in favor of simply using the new threading being done within the core. Another PR will make the same change on Android. Signed-off-by: Michael Rebello <me@michaelrebello.com>
junr03
approved these changes
Oct 21, 2019
Member
junr03
left a comment
junr03
left a comment
There was a problem hiding this comment.
Yep, this is what I had in mind based on our discussion
junr03
added a commit
that referenced
this pull request
Oct 22, 2019
Description: "Recent changes (namely #498) made it unnecessary for the platform-level clients to start Envoy on newly spawned threads. In fact, these changes actually introduced potential races where consumers of the platform clients could end up calling send on engines that hadn't finished starting on these threads." This PR removes the custom threading logic in Kotlin in favor of simply using the new threading being done within the core. Parallel to #530. Risk Level: med - reduce threading complexity Testing: local app. Signed-off-by: Jose Nino <jnino@lyft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recent changes (namely #498) made it unnecessary for the platform-level clients to start Envoy on newly spawned threads. In fact, these changes actually introduced potential races where consumers of the platform clients could end up calling
sendon engines that hadn't finished starting on these threads.This PR removes the custom threading logic in Swift in favor of simply using the new threading being done within the core. Another PR will make the same change on Android: #531.
Signed-off-by: Michael Rebello me@michaelrebello.com