Closed
Conversation
Signed-off-by: GitHub Action <noreply@github.com>
Contributor
|
/retest |
Contributor
|
There's a legitimate breakage here that I haven't fully thought through how to handle:
|
Contributor
|
It seems to be used in tests only but I have some recollection of this feature flag. I am sure that at some point it was used in config.cc but it does not seem to be used in there anymore. I found that Lyft internal discussion related to that runtime flag https://lyft.slack.com/archives/CLJGGN2JJ/p1647436776083709. Its usage was introduced in #2105 |
Contributor
|
I found a PR that removed It looks that it should be safe to remove the usage of that runtime flags from our tests - that should make the PR green. |
Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com>
Contributor
|
/retest |
Contributor
|
After a little bit more of an investigation. We removed Back to the failures in here. After the removal of
|
Contributor
Envoy Mobile Logs from a failing test |
Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com>
Contributor
|
Copy-pasted @alyssawilk's fix from #2657 in 4fc0f22 |
alyssawilk
pushed a commit
that referenced
this pull request
Nov 3, 2022
Description: Remove the use of removed override_request_timeout_by_gateway_timeout upstream Envoy flag from Swift tests. The flag was removed from the main config.cc as part of #2296 file months ago. The original removal introduced a bug as filter's onError callback started being called twice - this PR fixes this issue. Update EM code to correctly handle stream idle. See #2639 for more details. Fixes #2108. Risk Level: Medium, touches stream onDestroy code. Testing: Unit/Integration tests. Docs Changes: N/A Release Notes: N/A Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com>
Contributor
|
Closing as #2659 was merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated changes by create-pull-request GitHub action