Skip to content

Register getaddrinfo in extension_registry #2627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alyssawilk merged 4 commits into from
Oct 24, 2022
Merged

Register getaddrinfo in extension_registry #2627

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
315073b
1
caschoener Aug 15, 2022
5ef0312
Revert "1"
caschoener Sep 8, 2022
73a2a1c
copied from internal
caschoener Oct 20, 2022
fd1b809
format
caschoener Oct 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions envoy_build_config/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ envoy_cc_library(
"@envoy//source/extensions/filters/http/router:config",
"@envoy//source/extensions/filters/network/http_connection_manager:config",
"@envoy//source/extensions/http/header_formatters/preserve_case:config",
"@envoy//source/extensions/network/dns_resolver/getaddrinfo:config",
"@envoy//source/extensions/stat_sinks/metrics_service:config",
"@envoy//source/extensions/stat_sinks/statsd:config",
"@envoy//source/extensions/transport_sockets/http_11_proxy:upstream_config",
Expand Down
2 changes: 2 additions & 0 deletions envoy_build_config/extension_registry.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
#include "source/extensions/transport_sockets/tls/cert_validator/default_validator.h"
#include "source/extensions/transport_sockets/tls/config.h"
#include "source/extensions/upstreams/http/generic/config.h"
#include "source/extensions/network/dns_resolver/getaddrinfo/getaddrinfo.h"

#include "extension_registry_platform_additions.h"
#include "library/common/extensions/filters/http/assertion/config.h"
Expand Down Expand Up @@ -67,6 +68,7 @@ void ExtensionRegistry::registerFactories() {
Envoy::Upstream::forceRegisterLogicalDnsClusterFactory();
ExtensionRegistryPlatformAdditions::registerFactories();
Router::forceRegisterUpstreamCodecFilterFactory();
Envoy::Network::forceRegisterGetAddrInfoDnsResolverFactory();

// TODO: add a "force initialize" function to the upstream code, or clean up the upstream code
// in such a way that does not depend on the statically initialized variable.
Expand Down