Cronvoy: Map EM Errors to Cronet API Errors (#1594)#2568
Merged
RyanTheOptimist merged 17 commits intoenvoyproxy:mainfrom Oct 20, 2022
Merged
Cronvoy: Map EM Errors to Cronet API Errors (#1594)#2568RyanTheOptimist merged 17 commits intoenvoyproxy:mainfrom
RyanTheOptimist merged 17 commits intoenvoyproxy:mainfrom
Conversation
colibie
force-pushed
the
cronvoy_errors
branch
from
b3a66bb to
42356d5
Compare
colibie
force-pushed
the
cronvoy_errors
branch
from
8e023e7 to
b3a66bb
Compare
Signed-off-by: Chidera Olibie <colibie@google.com>
colibie
force-pushed
the
cronvoy_errors
branch
from
b3a66bb to
103654c
Compare
Contributor
Author
|
@Danstahrg for cronet review |
Danstahrg
reviewed
Sep 22, 2022
Danstahrg
reviewed
Sep 22, 2022
Danstahrg
reviewed
Sep 22, 2022
Danstahrg
reviewed
Sep 22, 2022
Danstahrg
reviewed
Sep 22, 2022
Danstahrg
reviewed
Sep 22, 2022
Danstahrg
left a comment
Danstahrg
left a comment
There was a problem hiding this comment.
General recommendation: Consider splitting the tangential refactors to a separate change, it makes the pull request more self explanatory.
Signed-off-by: Chidera Olibie <colibie@google.com>
…rrors Signed-off-by: Chidera Olibie <colibie@google.com>
Signed-off-by: Chidera Olibie <colibie@google.com>
…rrors Signed-off-by: Chidera Olibie <colibie@google.com>
Signed-off-by: Chidera Olibie <colibie@google.com>
Signed-off-by: Chidera Olibie <colibie@google.com>
Signed-off-by: Chidera Olibie <colibie@google.com>
Danstahrg
reviewed
Oct 6, 2022
Danstahrg
reviewed
Oct 6, 2022
library/java/org/chromium/net/impl/NativeCronetEngineBuilderImpl.java
Outdated
Show resolved
Hide resolved
test/java/org/chromium/net/testing/MockUrlRequestJobFactory.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Chidera Olibie <colibie@google.com>
Signed-off-by: Chidera Olibie <colibie@google.com>
Signed-off-by: Chidera Olibie <colibie@google.com>
Danstahrg
previously approved these changes
Oct 10, 2022
Contributor
Author
|
@Augustyniak could you please review? This resolves the TODO you added in PR2565 @alyssawilk for the c++ |
Augustyniak
previously approved these changes
Oct 10, 2022
Contributor
Augustyniak
left a comment
Augustyniak
left a comment
There was a problem hiding this comment.
+1 for addressing TODO, thank you!
Contributor
|
-> Ryan for C++ as I'm largely out this week |
Signed-off-by: Chidera Olibie <colibie@google.com>
Signed-off-by: Chidera <colibie@google.com>
Moved the testread filter to test/integration/filters. This is where @envoy's own test-only filters are. Signed-off-by: Chidera Olibie <colibie@google.com>
RyanTheOptimist
approved these changes
Oct 18, 2022
colibie
added a commit
to colibie/envoy-mobile
that referenced
this pull request
Oct 22, 2022
…roxy#2568) Description: Converts EM's responseFlags to Cronet's API Errors Additional Description: Note that this change does not include ERR_NETWORK_CHANGED, ERR_INTERNET_DISCONNECT and QUIC_PROTOCOL_FAILED as they aren't implemented yet Risk Level: Low Testing: Test included Docs Changes: n/a Release Notes: n/a Signed-off-by: Chidera Olibie <colibie@google.com> Signed-off-by: Chidera <colibie@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: Converts EM's responseFlags to Cronet's API Errors
Additional Description: Note that this change does not include ERR_NETWORK_CHANGED, ERR_INTERNET_DISCONNECT and QUIC_PROTOCOL_FAILED as they aren't implemented yet
Risk Level: Low
Testing: Test included
Docs Changes: n/a
Release Notes: n/a
[Optional Fixes #Issue]
[Optional Deprecated:]