Skip to content

engine: remove outdated comment about registerFactories() #2412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jpsim merged 1 commit into from
Jul 8, 2022
Merged

engine: remove outdated comment about registerFactories() #2412

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions library/common/engine.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,6 @@ Engine::Engine(envoy_engine_callbacks callbacks, envoy_logger logger,
envoy_event_tracker event_tracker)
: callbacks_(callbacks), logger_(logger), event_tracker_(event_tracker),
dispatcher_(std::make_unique<Event::ProvisionalDispatcher>()) {
// Ensure static factory registration occurs on time.
// TODO: ensure this is only called one time once multiple Engine objects can be allocated.
// https://github.com/envoyproxy/envoy-mobile/issues/332
ExtensionRegistry::registerFactories();

// TODO(Augustyniak): Capturing an address of event_tracker_ and registering it in the API
Expand Down