Merged
Conversation
jpsim
previously approved these changes
Jun 16, 2022
Contributor
jpsim
left a comment
jpsim
left a comment
There was a problem hiding this comment.
I looked through the upstream PRs and nothing sticks out as being problematic for EM.
Contributor
|
Needs some updates to account for envoyproxy/envoy#21648 |
Signed-off-by: GitHub Action <noreply@github.com>
envoy-bot
force-pushed
the
update-envoy-218e317
branch
from
f7f95cf to
4ceeb6a
Compare
Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com>
Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com>
Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com>
Contributor
|
@jpsim Fixed what needed to be fixed as part of 0bf4729. Thank you for investigating CI issues and sharing your findings with regards to their source - it was helpful! Bumped Envoy sha one more time - this time to #665b4d5. That's just so that we pick up envoyproxy/envoy#21803 which we kind of cherry picked into Envoy Mobile as part of the last Envoy sha bump that used non-main commit sha #2380 |
Contributor
|
@goaway This should be ready for a review. Pls take a look |
goaway
approved these changes
Jun 24, 2022
jpsim
added a commit
that referenced
this pull request
Jun 27, 2022
To prevent it from force-pushing to an existing branch like it did in #2373 Signed-off-by: JP Simard <jp@jpsim.com>
Augustyniak
pushed a commit
that referenced
this pull request
Jun 28, 2022
Automated changes by create-pull-request GitHub action with manual updates applied on top of it. Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com>
jpsim
added a commit
that referenced
this pull request
Jun 28, 2022
* origin/main: Update Envoy to e792008a66f (#2391) swift: fix docstrings and docstring linter (#2389) ci: change submodule_update PR branch name to use a timestamp strategy (#2387) Update Envoy (#2385) bazel: bump rules_apple and rules_swift to latest releases (#2384) Bump Lyft Support Rotation (#2386) Update Envoy to 665b4d5 (#2373) config: fixing apple dns v2 (#2378) Make CI jobs depend on Envoy build CI job (#2381) release notes: update for #2379 (#2382) android: add experimental option to force all connections to use IPv6 (#2379) Bump Envoy sha to f49d4f2 (#2380) Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
added a commit
to envoyproxy/envoy
that referenced
this pull request
Nov 29, 2022
#2387) To prevent it from force-pushing to an existing branch like it did in envoyproxy/envoy-mobile#2373 Signed-off-by: JP Simard <jp@jpsim.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated changes by create-pull-request GitHub action