Skip to content

config: add additional comment to disallow_global_stats #2371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jpsim merged 1 commit into from
Jun 15, 2022
Merged

config: add additional comment to disallow_global_stats #2371

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions library/common/config/config.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -509,6 +509,7 @@ stats_sinks: *stats_sinks
static_layer:
envoy:
# This disables envoy bug stats, which are filtered out of our stats inclusion list anyway
# Global stats do not play well with engines with limited lifetimes
disallow_global_stats: true
reloadable_features:
allow_multiple_dns_addresses: *dns_multiple_addresses
Expand Down