api: return opaque engine handle in onEngineRunning#2368
Closed
api: return opaque engine handle in onEngineRunning#2368
onEngineRunning#2368Conversation
To support interop between the Swift/Kotlin and C++ APIs. Signed-off-by: JP Simard <jp@jpsim.com>
Signed-off-by: JP Simard <jp@jpsim.com>
Signed-off-by: JP Simard <jp@jpsim.com>
Signed-off-by: JP Simard <jp@jpsim.com>
Signed-off-by: JP Simard <jp@jpsim.com>
Signed-off-by: JP Simard <jp@jpsim.com>
Signed-off-by: JP Simard <jp@jpsim.com>
Signed-off-by: JP Simard <jp@jpsim.com>
Signed-off-by: JP Simard <jp@jpsim.com>
Signed-off-by: JP Simard <jp@jpsim.com>
Signed-off-by: JP Simard <jp@jpsim.com>
Signed-off-by: JP Simard <jp@jpsim.com>
I can't get the tests to run locally and they fail on CI. Punting on this for now. Signed-off-by: JP Simard <jp@jpsim.com>
Contributor
Author
|
I'll go with a different approach. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To support interop between APIs across different languages.
This is needed to support the engine singleton removal work in #2129 because previously no matter the language, you could always assume that the engine handle would be
1, but with the singleton removed, we need to expose a mechanism to pass the engine instance from the higher level language APIs to the C++ APIs.Risk Level: Moderate
Testing: Unit tests, integration tests and in Lyft's downstream Envoy Mobile cross-language integration
Docs Changes: Updated
Release Notes: Added
To Do:
Signed-off-by: JP Simard jp@jpsim.com