Merged
Conversation
These are already being filtered out of our stats inclusion list, so this isn't a user-facing change, but this is needed to support the singleton removal work in #2129. Splitting this out into its own PR to reduce the scope of the singleton removal change. Signed-off-by: JP Simard <jp@jpsim.com>
alyssawilk
approved these changes
Jun 15, 2022
Contributor
alyssawilk
left a comment
alyssawilk
left a comment
There was a problem hiding this comment.
LGTM though it might be worth explaining why (global stats not working for multi-envoy)
Contributor
Author
Sure. Global stats are used to emit events when Since we're not using this feature by configuration, it's easiest to just remove it as I'm doing here. |
Contributor
|
haha I meant in the code, but worst case folks can blame and look a the PR :-P |
Contributor
Author
|
Added some more inline in the code here #2371 |
Augustyniak
pushed a commit
that referenced
this pull request
Jun 28, 2022
These are already being filtered out of our stats inclusion list, so this isn't a user-facing change, but this is needed to support the singleton removal work in #2129. Splitting this out into its own PR to reduce the scope of the singleton removal change. Co-authored-by: alyssawilk <alyssar@chromium.org> Signed-off-by: JP Simard <jp@jpsim.com> Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are already being filtered out of our stats inclusion list, so this isn't a user-facing change, but this is needed to support the singleton removal work in #2129.
Splitting this out into its own PR to reduce the scope of the singleton removal change.
Risk Level: Low
Testing: None
Docs Changes: N/A, not a user-facing change
Release Notes: N/A, not a user-facing change