Merged
Conversation
Bitcode is all but dead at this point. Here's a deprecation note from the Xcode 14 beta 1 release notes: https://developer.apple.com/documentation/Xcode-Release-Notes/xcode-14-release-notes > Starting with Xcode 14, bitcode is no longer required for watchOS and > tvOS applications, and the App Store no longer accepts bitcode > submissions from Xcode 14. > Xcode no longer builds bitcode by default and generates a warning > message if a project explicitly enables bitcode: “Building with > bitcode is deprecated. Please update your project and/or target > settings to disable bitcode.” The capability to build with bitcode > will be removed in a future Xcode release. IPAs that contain bitcode > will have the bitcode stripped before being submitted to the App > Store. Debug symbols for past bitcode submissions remain available > for download. (86118779) Signed-off-by: JP Simard <jp@jpsim.com>
Signed-off-by: JP Simard <jp@jpsim.com>
There are no longer any bad CRC errors, and bazel's compression is slightly better than the system's `zip` (94MB vs 97MB). Signed-off-by: JP Simard <jp@jpsim.com>
Contributor
Author
|
This brings the xcframework release zip size down from 352MB to 94MB. |
keith
approved these changes
Jun 9, 2022
jpsim
added a commit
that referenced
this pull request
Jun 14, 2022
* origin/main: (33 commits) iOS: fix xcframework upload in release workflow (#2366) config: hopefully fixing C++ config default for apple (#2355) Update Envoy (#2364) Bump Lyft Support Rotation (#2365) ci: pin external GitHub Action (#2363) cleanup: fix warning in JNI layer (#2361) cleanup: convert some more uses of NULL to nullptr (#2359) cleanup: consistently use nullptr in cc contexts (#2351) cleanup: remove unused function and resolve warning (#2350) iOS: add configurable gzip and brotli decompression options (#2349) iOS: stop embedding bitcode in releases (#2347) ci: update Android setup (#2354) docs: update the list of clusters (#2344) bazel: update rules_apple (#2346) iOS: add a way to disable network monitoring (#2345) api: adding brotli knobs (#2342) android: create persistent SharedPreferences-based KV store (#2319) ios: add support for registering a platform KV store (#2334) builder: making compressor configurable (#2321) iOS: add SwiftPM example (#2333) ... Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
added a commit
that referenced
this pull request
Jun 14, 2022
* origin/main: (33 commits) iOS: fix xcframework upload in release workflow (#2366) config: hopefully fixing C++ config default for apple (#2355) Update Envoy (#2364) Bump Lyft Support Rotation (#2365) ci: pin external GitHub Action (#2363) cleanup: fix warning in JNI layer (#2361) cleanup: convert some more uses of NULL to nullptr (#2359) cleanup: consistently use nullptr in cc contexts (#2351) cleanup: remove unused function and resolve warning (#2350) iOS: add configurable gzip and brotli decompression options (#2349) iOS: stop embedding bitcode in releases (#2347) ci: update Android setup (#2354) docs: update the list of clusters (#2344) bazel: update rules_apple (#2346) iOS: add a way to disable network monitoring (#2345) api: adding brotli knobs (#2342) android: create persistent SharedPreferences-based KV store (#2319) ios: add support for registering a platform KV store (#2334) builder: making compressor configurable (#2321) iOS: add SwiftPM example (#2333) ... Signed-off-by: JP Simard <jp@jpsim.com>
Augustyniak
pushed a commit
that referenced
this pull request
Jun 28, 2022
Bitcode is all but dead at this point. Here's a deprecation note from the Xcode 14 beta 1 release notes: https://developer.apple.com/documentation/Xcode-Release-Notes/xcode-14-release-notes > Starting with Xcode 14, bitcode is no longer required for watchOS and > tvOS applications, and the App Store no longer accepts bitcode > submissions from Xcode 14. > Xcode no longer builds bitcode by default and generates a warning > message if a project explicitly enables bitcode: “Building with > bitcode is deprecated. Please update your project and/or target > settings to disable bitcode.” The capability to build with bitcode > will be removed in a future Xcode release. IPAs that contain bitcode > will have the bitcode stripped before being submitted to the App > Store. Debug symbols for past bitcode submissions remain available > for download. (86118779) * Don't recompress xcarchive There are no longer any bad CRC errors, and bazel's compression is slightly better than the system's `zip` (94MB vs 97MB). Signed-off-by: JP Simard <jp@jpsim.com> Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bitcode is all but dead at this point.
Here's a deprecation note from the Xcode 14 beta 1 release notes:
https://developer.apple.com/documentation/Xcode-Release-Notes/xcode-14-release-notes