Skip to content

tests: add -Xcheck:jni to kotlin integration tests by default#2269

Merged
goaway merged 1 commit intomainfrom
ms/jni-check
May 12, 2022
Merged

tests: add -Xcheck:jni to kotlin integration tests by default#2269
goaway merged 1 commit intomainfrom
ms/jni-check

Conversation

@goaway
Copy link
Contributor

@goaway goaway commented May 12, 2022

Signed-off-by: Mike Schore mike.schore@gmail.com

Signed-off-by: Mike Schore <mike.schore@gmail.com>
@goaway goaway requested review from Augustyniak and snowp May 12, 2022 11:41
Copy link
Contributor

@jpsim jpsim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic. Based on my reading of the docs for the option there isn't much of a downside to enabling this for tests, so this works for me.

@jpsim
Copy link
Contributor

jpsim commented May 12, 2022

I do wonder if this would have caught this return value mismatch: #2252

@goaway
Copy link
Contributor Author

goaway commented May 12, 2022

Thanks @jpsim!

@goaway goaway merged commit 4400c76 into main May 12, 2022
@goaway goaway deleted the ms/jni-check branch May 12, 2022 21:20
jpsim added a commit that referenced this pull request May 17, 2022
* origin/main: (97 commits)
  docs: update python packages to work with Python 3.10 (#2286)
  test: adding a cancel test, cleaning up copy-paste code (#2283)
  envoy: update to d88f31b (#2279)
  api: disallow setting 'host' header directly (#2275)
  android: add support for registering a platform KV store (#2134)
  Bump Lyft Support Rotation (#2278)
  tools: Enable the VSCode completion db to use bazelisk if available (#2277)
  Release v0.4.6.20220513-4
  Fix android_release_deploy
  Release v0.4.6.20220513-3
  Release v0.4.6.20220513-2
  net: enable happy eyeballs by default (#2272)
  git: avoid merge conflicts when adding changelog entries (#2273)
  docs: fix sphinx reference mismatch warning (#2274)
  tests: add -Xcheck:jni to kotlin integration tests by default (#2269)
  configuration: enable h2 ping by default (#2270)
  Add version history entries for user-facing changes (#2271)
  configuration: filter unroutable addresses on Android by default (#2267)
  Integrate rules_xcodeproj (#2263)
  Add assert when failing to get_env (#2253)
  ...

Signed-off-by: JP Simard <jp@jpsim.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants