Continuous writes make onResponseHeaders to never happen#2212
Closed
carloseltuerto wants to merge 1 commit intoenvoyproxy:mainfrom
Closed
Continuous writes make onResponseHeaders to never happen#2212carloseltuerto wants to merge 1 commit intoenvoyproxy:mainfrom
carloseltuerto wants to merge 1 commit intoenvoyproxy:mainfrom
Conversation
…ever happen Signed-off-by: Charles Le Borgne <cleborgne@google.com>
carloseltuerto
changed the title
RyanTheOptimist
added a commit
to RyanTheOptimist/envoy-mobile
that referenced
this pull request
Apr 27, 2022
but scheduling repeated onSendWindowAvailable calls in the next dispatcher iteration. Adds the regression test Charles cooked up in envoyproxy#2212 Fixes envoyproxy#2213
RyanTheOptimist
added a commit
to RyanTheOptimist/envoy-mobile
that referenced
this pull request
Apr 27, 2022
by scheduling repeated onSendWindowAvailable calls in the next dispatcher iteration. Adds the regression test Charles cooked up in envoyproxy#2212 Fixes envoyproxy#2213 Signed-off-by: Ryan Hamilton <rch@google.com>
goaway
pushed a commit
that referenced
this pull request
May 10, 2022
…g, (#2221) Description: Fix Envoy Mobile bug where writing prevents the read loop from running, by scheduling repeated onSendWindowAvailable calls in the next dispatcher iteration. Adds the regression test Charles cooked up in #2212 Fixes #2213 Risk Level: Low Testing: New regression test Docs Changes: N/A Release Notes: N/A Signed-off-by: Ryan Hamilton <rch@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For testing - do not submit.
Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Signed-off-by: Charles Le Borgne cleborgne@google.com