Skip to content

cleanup: remove comment in Http::Client that no longer applies #2203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
goaway merged 1 commit into from
May 3, 2022
Merged

cleanup: remove comment in Http::Client that no longer applies #2203

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions library/common/http/client.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -590,12 +590,6 @@ namespace {
const LowerCaseString ClusterHeader{"x-envoy-mobile-cluster"};
const LowerCaseString ProtocolHeader{"x-envoy-mobile-upstream-protocol"};

// Alternate clusters included here are a stopgap to make it less likely for a given connection
// class to suffer "catastrophic" failure of all outbound requests due to a network blip, by
// distributing requests across a minimum of two potential connections per connection class.
// Long-term we will be working to generally provide more responsive connection handling within
// Envoy itself.

const char* BaseCluster = "base";
const char* H2Cluster = "base_h2";
const char* H3Cluster = "base_h3";
Expand Down