Skip to content

build: remove rules_python override#2197

Merged
mattklein123 merged 1 commit intomainfrom
fix_rules_python
Apr 25, 2022
Merged

build: remove rules_python override#2197
mattklein123 merged 1 commit intomainfrom
fix_rules_python

Conversation

@mattklein123
Copy link
Member

No longer needed as Envoy's is newer and this version is breaking
private fuzz tests.

Risk Level: Low
Testing: Existing tests
Docs Changes: N/A
Release Notes: N/A

No longer needed as Envoy's is newer and this version is breaking
private fuzz tests.

Signed-off-by: Matt Klein <mklein@lyft.com>
Copy link
Member

@phlax phlax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mattklein123
Copy link
Member Author

/retest

@jpsim
Copy link
Contributor

jpsim commented Apr 25, 2022

EngFlow CI hasn't been working today, reported in #envoy-mobile-engflow-ci a few hours ago, but haven't heard back yet.

@mattklein123
Copy link
Member Author

/retest

@jpsim
Copy link
Contributor

jpsim commented Apr 25, 2022

EngFlow fixed the issues we were seeing earlier today, but I don't think /retest works on this repo. I've manually restarted the failing jobs.

@mattklein123
Copy link
Member Author

Ah OK I wasn't sure about that, thank you. We should make /retest work. :)

@mattklein123 mattklein123 merged commit 23dc87f into main Apr 25, 2022
@mattklein123 mattklein123 deleted the fix_rules_python branch April 25, 2022 22:46
@jpsim
Copy link
Contributor

jpsim commented Apr 26, 2022

Adding support for /retest: #2219

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants