Merged
Conversation
* Fix summary string. * Automatically set version based on the contents of the `VERSION` file. * Add `APPLICATION_EXTENSION_API_ONLY` so Envoy Mobile can be used in app extension targets if desired. * Advertise support for Swift 5.6 * Add `Gemfile` to pin what version of CocoaPods we use. * Add `release_validation` GitHub Action to run on PRs and `main` commits to validate the podspec. Other release validation checks can be added here in the future. Signed-off-by: JP Simard <jp@jpsim.com>
Signed-off-by: JP Simard <jp@jpsim.com>
Augustyniak
previously approved these changes
Apr 21, 2022
Contributor
Augustyniak
left a comment
Augustyniak
left a comment
There was a problem hiding this comment.
Nice! Great to see this being improved. Thank you for working on this
| cocoapods_lib_lint: | ||
| name: cocoapods_lib_lint | ||
| runs-on: macos-11 | ||
| timeout-minutes: 120 |
Contributor
There was a problem hiding this comment.
Does the timeout has to be so high? Just curious
Contributor
Author
There was a problem hiding this comment.
No, just copy pasted from a different action. Reduced to 20. The last run took 5 minutes, so 4x headroom should be plenty.
| Pod::Spec.new do |s| | ||
| s.name = 'EnvoyMobile' | ||
| s.version = '0.4.5' | ||
| s.version = `cat VERSION`.chomp |
Signed-off-by: JP Simard <jp@jpsim.com>
Augustyniak
approved these changes
Apr 21, 2022
jpsim
added a commit
that referenced
this pull request
Apr 25, 2022
The version in the podspec no longer needs to be manually bumped as of #2175. Signed-off-by: JP Simard <jp@jpsim.com>
Merged
jpsim
added a commit
that referenced
this pull request
Apr 26, 2022
The version in the podspec no longer needs to be manually bumped as of #2175. Signed-off-by: JP Simard <jp@jpsim.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VERSIONfile.APPLICATION_EXTENSION_API_ONLYso Envoy Mobile can be used in app extension targets if desired.Gemfileto pin what version of CocoaPods we use.release_validationGitHub Action to run on PRs andmaincommits to validate the podspec. Other release validation checks can be added here in the future.Risk Level: Low, we haven't pushed CocoaPods releases in over two years
Testing: CI job
Docs Changes: N/A
Release Notes: N/A