Skip to content

build: export flatbuffer jvm dep #2147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
snowp merged 1 commit into from
Apr 4, 2022
Merged

build: export flatbuffer jvm dep #2147

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions bazel/flatbuffers.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ def envoy_mobile_flatbuffers_library(name, srcs, namespace, types):
name = "{}_fb_kt_lib".format(name),
srcs = [":{}_fb_kt_srcs".format(name)],
deps = ["@maven//:com_google_flatbuffers_flatbuffers_java"],
exports = ["@maven//:com_google_flatbuffers_flatbuffers_java"],
)

swift_intermediate_outputs = ["{}_generated.swift".format(f.replace(".fbs", "")) for f in srcs]
Expand Down
3 changes: 2 additions & 1 deletion bazel/kotlin_lib.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ def native_lib_name(native_dep):
lib_name = native_dep.split(".so")[0]
return lib_name

def envoy_mobile_kt_library(name, visibility = None, srcs = [], deps = []):
def envoy_mobile_kt_library(name, visibility = None, srcs = [], deps = [], exports = []):
# These source files must be re-exported to the kotlin custom library rule to ensure their
# inclusion. This is used to work around testing visibility.
native.filegroup(
Expand All @@ -32,6 +32,7 @@ def envoy_mobile_kt_library(name, visibility = None, srcs = [], deps = []):
name = name,
srcs = srcs,
deps = deps,
exports = exports,
visibility = visibility,
)

Expand Down