Skip to content

envoy: c911818721586 #2107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
junr03 merged 2 commits into from
Mar 17, 2022
Merged

envoy: c911818721586 #2107

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6528347
envoy: c911818721586
Mar 16, 2022
dbc3091
Merge branch 'main' into c911818721586
Mar 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion envoy
Open in desktop
Submodule envoy updated 134 files
1 change: 1 addition & 0 deletions library/common/config/config.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,6 +326,7 @@ R"(
dns_cache_config: *dns_cache_config
transport_socket: *base_tls_socket
upstream_connection_options: &upstream_opts
set_local_interface_name_on_upstream_connections: true
Copy link
Contributor

@jpsim jpsim Mar 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How much of a perf impact does this have for EM use cases compared to turning it off? Would it be worth offering as a config option or turning off when log level is set to some values?

Copy link
Member Author

@junr03 junr03 Mar 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#2111 good point. Alternatively there is further work in upstream envoy that can make this functionality more performant.

For this PR though I'm biased to leave it on by default as that has been the case for all experiments we've run in the last quarter.

Copy link
Contributor

@jpsim jpsim Mar 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I'm ok with that too, but was curious if you had measured the impact on us.

tcp_keepalive:
keepalive_interval: 5
keepalive_probes: 1
Expand Down