Skip to content

update envoy to latest #2094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
snowp merged 4 commits into from
Mar 11, 2022
Merged

update envoy to latest #2094

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5ceadff
update envoy to latest
Mar 11, 2022
1c2e163
revert pgv overrides
Mar 11, 2022
842e9db
add gazelle
Mar 11, 2022
0891fdf
fix signature
Mar 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion WORKSPACE
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
workspace(name = "envoy_mobile")

# TODO[fz]: Remove once envoy updates PGV
# The pgv imports require gazelle to be available early on.
Copy link
Copy Markdown
Contributor

@jpsim jpsim Mar 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I haven't yet found a way to re-use the definition in Envoy for this.

load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
http_archive(
name = "bazel_gazelle",
Expand Down
18 changes: 0 additions & 18 deletions bazel/envoy_mobile_repositories.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,30 +10,12 @@ def envoy_mobile_repositories():
urls = ["https://github.com/google/bazel-common/archive/413b433b91f26dbe39cdbc20f742ad6555dd1e27.zip"],
)

# Uses PGV that includes the CC NOP template to disable validation.
# TODO(fz): Remove this once PGV is updated on envoy
override_pgv()

upstream_envoy_overrides()
swift_repos()
kotlin_repos()
android_repos()
python_repos()

def override_pgv():
go_repository(
name = "com_github_lyft_protoc_gen_star",
importpath = "github.com/lyft/protoc-gen-star",
sum = "h1:xOpFu4vwmIoUeUrRuAtdCrZZymT/6AkW/bsUWA506Fo=",
version = "v0.6.0",
)

git_repository(
name = "com_envoyproxy_protoc_gen_validate",
commit = "79071f0f8b04188b297a0517a6e55b2d3641ab5a",
remote = "https://github.com/envoyproxy/protoc-gen-validate"
)

def upstream_envoy_overrides():
# Workaround due to a Detekt version compatibility with protobuf: https://github.com/envoyproxy/envoy-mobile/issues/1869
http_archive(
Expand Down
2 changes: 1 addition & 1 deletion envoy
Open in desktop
Submodule envoy updated 412 files
2 changes: 1 addition & 1 deletion library/common/http/client.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,7 @@ class Client : public Logger::Loggable<Logger::Id::http> {
// It only has an effect in explicit flow control mode, where when all buffers are drained,
// on_send_window_available callbacks are called.
void readDisable(bool disable) override;
uint32_t bufferLimit() override {
uint32_t bufferLimit() const override {
// 1Mb
return 1024000;
}
Expand Down