Skip to content

Decompress even when no-transform is specified #1995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
buildbreaker merged 9 commits into from
Jan 7, 2022
Merged

Decompress even when no-transform is specified #1995

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
f2c4988
Decompress even when `no-transform` is specified
jpsim Jan 4, 2022
6c49731
Empty commit
jpsim Jan 7, 2022
1d11327
Try removing `--config=remote-ci-macos`
jpsim Jan 7, 2022
e8f5dcf
Mark integration tests with `no-remote-exec`
jpsim Jan 7, 2022
8da9120
fixup! Mark integration tests with `no-remote-exec`
jpsim Jan 7, 2022
13ac627
Add entry in version history
jpsim Jan 7, 2022
510c5f9
Empty commit
jpsim Jan 7, 2022
378d713
fixup! Empty commit
jpsim Jan 7, 2022
5b07687
fixup! fixup! Empty commit
jpsim Jan 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions bazel/apple_test.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ load("@rules_cc//cc:defs.bzl", "objc_library")
# ],
# )
#
def envoy_mobile_swift_test(name, srcs, data = [], deps = [], repository = ""):
def envoy_mobile_swift_test(name, srcs, data = [], deps = [], tags = [], repository = ""):
test_lib_name = name + "_lib"
swift_library(
name = test_lib_name,
Expand All @@ -36,9 +36,10 @@ def envoy_mobile_swift_test(name, srcs, data = [], deps = [], repository = ""):
data = data,
deps = [test_lib_name],
minimum_os_version = "11.0",
tags = tags,
)

def envoy_mobile_objc_test(name, srcs, data = [], deps = []):
def envoy_mobile_objc_test(name, srcs, data = [], deps = [], tags = []):
test_lib_name = name + "_lib"
objc_library(
name = test_lib_name,
Expand All @@ -53,4 +54,5 @@ def envoy_mobile_objc_test(name, srcs, data = [], deps = []):
data = data,
deps = [test_lib_name],
minimum_os_version = "11.0",
tags = tags,
)
2 changes: 2 additions & 0 deletions docs/root/intro/version_history.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ Pending Release

Bugfixes:

- Decompressor: decompress even when `no-transform` is specified (:issue:`#1995 <1995>`)

Features:

0.4.4 (December 30, 2021)
Expand Down
2 changes: 1 addition & 1 deletion envoy
Open in desktop
Submodule envoy updated 109 files
3 changes: 3 additions & 0 deletions library/common/config/config.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,6 +294,9 @@ R"(
enabled:
default_value: false
runtime_key: request_decompressor_enabled
response_direction_config:
common_config:
ignore_no_transform_header: true
- name: envoy.router
typed_config:
"@type": type.googleapis.com/envoy.extensions.filters.http.router.v3.Router
Expand Down
4 changes: 4 additions & 0 deletions test/common/integration/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,10 @@ envoy_cc_test(
name = "client_integration_test",
srcs = ["client_integration_test.cc"],
repository = "@envoy",
# TODO(jpsim): Fix remote execution for these tests
Copy link
Copy Markdown
Contributor Author

@jpsim jpsim Jan 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A change in Envoy has caused the integration tests to fail when executed remotely. I'm looking into it here: #1996

I'd rather not block this PR on that investigation though.

Copy link
Copy Markdown
Contributor Author

@jpsim jpsim Jan 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bisecting has identified that envoyproxy/envoy#19221 is responsible.

@alyssawilk considering you marked that PR as having a high risk level, do you think this is surfacing a real issue? Should we revert that change until we can better understand the reason these tests broke when executed remotely?

tags = [
"no-remote-exec",
],
deps = [
"//library/common/extensions/filters/http/local_error:config",
"//library/common/extensions/filters/http/local_error:filter_cc_proto",
Expand Down
4 changes: 4 additions & 0 deletions test/swift/integration/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,10 @@ envoy_mobile_swift_test(
"SetLoggerTest.swift",
"StatFlushIntegrationTest.swift",
],
# TODO(jpsim): Fix remote execution for these tests
tags = [
"no-remote-exec",
],
deps = [
":test_extensions",
"//library/objective-c:envoy_engine_objc_lib",
Expand Down