Merged
Conversation
added 2 commits
September 15, 2021 16:54
Signed-off-by: Jose Nino <jnino@lyft.com>
buildbreaker
previously approved these changes
Sep 15, 2021
Member
Author
|
#1804 is needed for this to go green |
added 2 commits
September 16, 2021 11:38
buildbreaker
force-pushed
the
per-try-idle
branch
from
380999c to
77614fb
Compare
Signed-off-by: Jose Nino <jnino@lyft.com>
…try-idle Signed-off-by: Jose Nino <jnino@lyft.com>
rebello95
approved these changes
Sep 17, 2021
|
|
||
| Specifies the length of time a stream should wait without a headers or data event before timing out. | ||
| Defaults to 15 seconds. | ||
| See `the Envoy docs <https://www.envoyproxy.io/docs/envoy/latest/api-v3/extensions/filters/network/http_connection_manager/v3/http_connection_manager.proto#envoy-v3-api-field-extensions-filters-network-http-connection-manager-v3-httpconnectionmanager-stream-idle-timeout>`_ |
Member
Author
There was a problem hiding this comment.
not sure why @buildbreaker updated. But still seems to generate correctly.
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
|
|
||
| Specifies the length of time a retry (including the initial attempt) should wait without a headers | ||
| or data event before timing out. Defaults to 15 seconds. |
Contributor
There was a problem hiding this comment.
Does this apply to trailers?
Member
Author
There was a problem hiding this comment.
Yes, this should say "wait for bytes". That would be more comprehensive.
Member
Author
There was a problem hiding this comment.
@buildbreaker let me fix this in a subsequent PR so we don't have to run CI on this again.
Member
Author
|
@buildbreaker going to merge so you and @rebello95 can wire up and we can test. |
Contributor
|
sounds good |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: expose the new per try idle timeout via the engine builder.
Risk Level: low
Testing: unit test
Docs Changes: added