Skip to content

update envoy submodule#1754

Closed
snowp wants to merge 2 commits intoenvoyproxy:mainfrom
snowp:update-envoy-2
Closed

update envoy submodule#1754
snowp wants to merge 2 commits intoenvoyproxy:mainfrom
snowp:update-envoy-2

Conversation

@snowp
Copy link
Contributor

@snowp snowp commented Aug 26, 2021

This brings in some new upstream changes that will help debugging, like envoyproxy/envoy#17833

Signed-off-by: Snow Pettersen snowp@lyft.com

Description: n/a
Risk Level: Medium
Testing: CI
Docs Changes: n/a
Release Notes: n/a

Signed-off-by: Snow Pettersen <snowp@lyft.com>
Augustyniak
Augustyniak previously approved these changes Aug 26, 2021
buildbreaker
buildbreaker previously approved these changes Aug 26, 2021
@alyssawilk
Copy link
Contributor

snow I think you need the config change from #1750

@snowp
Copy link
Contributor Author

snowp commented Aug 26, 2021

I think it also need a bazel build fix. Let's merge yours first and I'l deal with the incremental envoy upgrade here

Signed-off-by: Snow Pettersen <snowp@lyft.com>
@snowp snowp dismissed stale reviews from buildbreaker and Augustyniak via ebe8ce4 August 26, 2021 17:45
@snowp
Copy link
Contributor Author

snowp commented Aug 26, 2021

    Change Dir: /private/var/lib/engflow/worker/work/6/exec/bazel-out/ios-x86_64-min11.0-applebin_ios-ios_x86_64-fastbuild-ST-2da4e3d01b1a/bin/external/envoy/bazel/foreign_cc/event.build_tmpdir/CMakeFiles/CMakeTmp
    
    Run Build Command(s):ninja cmTC_b50d0 && [1/2] Building C object CMakeFiles/cmTC_b50d0.dir/testCCompiler.c.o
    clang: warning: using sysroot for 'MacOSX' but targeting 'iPhone' [-Wincompatible-sysroot]
    [2/2] Linking C executable cmTC_b50d0
    FAILED: cmTC_b50d0 
    : && /private/var/lib/engflow/worker/work/6/exec/external/local_config_cc/wrapped_clang -D_FORTIFY_SOURCE=1 -fstack-protector -fcolor-diagnostics -Wall -Wthread-safety -Wself-assign -fno-omit-frame-pointer -O0 -DDEBUG DEBUG_PREFIX_MAP_PWD=. -isysroot __BAZEL_XCODE_SDKROOT__ -F__BAZEL_XCODE_SDKROOT__/System/Library/Frameworks -F__BAZEL_XCODE_DEVELOPER_DIR__/Platforms/iPhoneSimulator.platform/Developer/Library/Frameworks -mios-simulator-version-min=11.0 -no-canonical-prefixes -Wno-builtin-macro-redefined -D__DATE__=\"redacted\" -D__TIMESTAMP__=\"redacted\" -D__TIME__=\"redacted\" -target x86_64-apple-ios -Wno-deprecated-declarations  -isysroot /Applications/Xcode_12.5.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.3.sdk -Wl,-search_paths_first -Wl,-headerpad_max_install_names  CMakeFiles/cmTC_b50d0.dir/testCCompiler.c.o -o cmTC_b50d0   && :
    clang: warning: using sysroot for 'MacOSX' but targeting 'iPhone' [-Wincompatible-sysroot]
    ld: building for iOS Simulator, but linking in .tbd built for macOS/Mac Catalyst, file '/Applications/Xcode_12.5.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.3.sdk/usr/lib/libSystem.tbd' for architecture x86_64
    clang: error: linker command failed with exit code 1 (use -v to see invocation)
    Error in child process '/usr/bin/xcrun'. 1
    /bin/sh: line 1: 44636 Abort trap: 6           /private/var/lib/engflow/worker/work/6/exec/external/local_config_cc/wrapped_clang -D_FORTIFY_SOURCE=1 -fstack-protector -fcolor-diagnostics -Wall -Wthread-safety -Wself-assign -fno-omit-frame-pointer -O0 -DDEBUG DEBUG_PREFIX_MAP_PWD=. -isysroot __BAZEL_XCODE_SDKROOT__ -F__BAZEL_XCODE_SDKROOT__/System/Library/Frameworks -F__BAZEL_XCODE_DEVELOPER_DIR__/Platforms/iPhoneSimulator.platform/Developer/Library/Frameworks -mios-simulator-version-min=11.0 -no-canonical-prefixes -Wno-builtin-macro-redefined -D__DATE__=\"redacted\" -D__TIMESTAMP__=\"redacted\" -D__TIME__=\"redacted\" -target x86_64-apple-ios -Wno-deprecated-declarations -isysroot /Applications/Xcode_12.5.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.3.sdk -Wl,-search_paths_first -Wl,-headerpad_max_install_names CMakeFiles/cmTC_b50d0.dir/testCCompiler.c.o -o cmTC_b50d0
    ninja: build stopped: subcommand failed.

Mysterious iOS failure - @keith any idea what might be happening here? https://github.com/envoyproxy/envoy-mobile/pull/1754/checks?check_run_id=3435665501

@keith
Copy link
Member

keith commented Aug 26, 2021

ughh. I guess my testing wasn't enough, we can do envoyproxy/envoy#17875 again for now

@junr03
Copy link
Member

junr03 commented Aug 27, 2021

closing in favor of #1760

@junr03 junr03 closed this Aug 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants