engine: add drainConnections API to platform layer#1731
Merged
Conversation
added 2 commits
August 19, 2021 15:07
Signed-off-by: Jose Nino <jnino@lyft.com>
Signed-off-by: Jose Nino <jnino@lyft.com>
added 3 commits
August 20, 2021 11:41
Signed-off-by: Jose Nino <jnino@lyft.com>
buildbreaker
approved these changes
Aug 20, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: this PR uses the main interface API exposed in #1729 and surfaces it for use in the platform layer
Risk Level: low - new API. However actual usage is high risk and should be monitored carefully.
Testing: swift and Kotlin integration tests.
Signed-off-by: Jose Nino jnino@lyft.com