Skip to content

http3: turning support up by default #1717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alyssawilk merged 15 commits into from
Sep 21, 2021
Merged

http3: turning support up by default #1717

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
02e1ab3
http3: turning support up by default
alyssawilk Aug 17, 2021
a5f6b33
try again
alyssawilk Aug 17, 2021
7a8f06b
update
alyssawilk Aug 25, 2021
6e8b7a1
Merge branch 'main' into http3
alyssawilk Sep 1, 2021
ab40666
Merge branch 'main' into http3
alyssawilk Sep 13, 2021
50bff4b
potential fix
alyssawilk Sep 13, 2021
a5fcc81
reverting submodule hack
alyssawilk Sep 13, 2021
70dc35d
quic is 15% size regression
alyssawilk Sep 13, 2021
7d29475
delta
alyssawilk Sep 14, 2021
9f72cfd
Merge branch 'main' into http3
alyssawilk Sep 14, 2021
2a1ce63
Merge branch 'main' into http3
alyssawilk Sep 16, 2021
bfcf9ca
ci
alyssawilk Sep 16, 2021
4c7ddc1
Merge branch 'main' into http3
alyssawilk Sep 21, 2021
dd6e58f
bump
alyssawilk Sep 21, 2021
d2e6223
bumping more
alyssawilk Sep 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .bazelrc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ build --incompatible_objc_compile_info_migration
build --features=-per_object_debug_info
# Suppress deprecated declaration warnings due to extensive transitive noise from protobuf.
build --copt -Wno-deprecated-declarations
build --@envoy//bazel:http3=False

@junr03 junr03 Sep 21, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add this to release-common so that our release builds don't yet include it?

@alyssawilk alyssawilk Sep 21, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will this mean we have to exempt quic tests from the release build somehow?
doable but it may make more sense to have this as a lyft-only thing, WDYT?

@junr03 junr03 Sep 21, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

talked offline. Happy to not compile h3 in our private build.


# Default flags for builds targeting iOS
# Manual stamping is necessary in order to get versioning information in the iOS
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/android_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ jobs:
javatestsmac:
name: java_tests_mac
runs-on: macos-11
timeout-minutes: 90
timeout-minutes: 120
steps:
- uses: actions/checkout@v1
with:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ios_build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
iosbuild:
name: ios_build
runs-on: macos-11
timeout-minutes: 75
timeout-minutes: 120
steps:
- uses: actions/checkout@v1
with:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ios_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
swifttests:
name: swift_tests
runs-on: macos-11
timeout-minutes: 90
timeout-minutes: 120
steps:
- uses: actions/checkout@v1
with:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/perf.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
sizecurrent:
name: size_current
runs-on: ubuntu-18.04
timeout-minutes: 90
timeout-minutes: 120
container:
image: envoyproxy/envoy-build-ubuntu:b51ac7a0f2cb5dd729984a379a301ce029ac765d
env:
Expand Down
2 changes: 1 addition & 1 deletion ci/test_size_regression.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

# Checks the absolute size and the relative size increase of a file.

MAX_SIZE=6600000 # 6.6MB
MAX_SIZE=7200000 # 7.2MB
MAX_PERC=2.0

if [ `uname` == "Darwin" ]
Expand Down