Merged
Conversation
added 3 commits
July 21, 2021 12:38
Signed-off-by: Jose Nino <jnino@lyft.com>
Signed-off-by: Jose Nino <jnino@lyft.com>
Member
Author
|
Heavy inspiration from #797 |
goaway
reviewed
Jul 21, 2021
goaway
reviewed
Jul 21, 2021
Contributor
|
Nice! Thank you @junr03! |
keith
previously approved these changes
Jul 21, 2021
| def _swift_header_collector(ctx): | ||
| return [ | ||
| DefaultInfo( | ||
| files = ctx.attr.library[CcInfo].compilation_context.headers, |
Member
There was a problem hiding this comment.
might want to assert that this only has 1 file to make sure it is what we expect, not a huge deal
| @@ -1,218 +0,0 @@ | |||
| """ | |||
| @@ -1,4 +1,4 @@ | |||
| #import <Envoy/Envoy-Swift.h> | |||
Member
There was a problem hiding this comment.
not sure if you consider this public API or not
added 2 commits
July 21, 2021 14:49
keith
reviewed
Jul 21, 2021
added 9 commits
July 21, 2021 17:00
Signed-off-by: Jose Nino <jnino@lyft.com>
Signed-off-by: Jose Nino <jnino@lyft.com>
Signed-off-by: Jose Nino <jnino@lyft.com>
Signed-off-by: Jose Nino <jnino@lyft.com>
Signed-off-by: Jose Nino <jnino@lyft.com>
Member
Author
keith
approved these changes
Jul 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: updates to bazel 4.1.0 by removing deprecated dependencies and bespoke build rules for swift.
Risk Level: low
Testing: CI
Signed-off-by: Jose Nino jnino@lyft.com