python: release GIL while calling terminate to avoid deadlock#1480
Closed
python: release GIL while calling terminate to avoid deadlock#1480
Conversation
Signed-off-by: Cerek Hillen <chillen@lyft.com>
goaway
approved these changes
May 18, 2021
Contributor
Author
|
unnecessary with #1379 merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: Alternative to #1379 for getting rid of the deadlocks. The deadlocks are caused by:
Engine::terminatewith GIL in hand, asks Thread 2, and then waits for it to die.EngineCallbacks::~EngineCallbacksto run, which attempts to grab the GIL.Risk Level: Low
Testing: ...a little convoluted. These deadlocks occur at process teardown, so I've been installing the envoy-requests wheel and making a pair of files:
and
and then running several of these until a deadlock occurs. You can also reproduce them by running several test jobs at the same time (
--runs_per_test), but I found the above method to result in a deadlock sooner.Docs Changes: N/A
Release Notes: N/A