Merged
Conversation
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
jmarantz
reviewed
Apr 9, 2019
Contributor
jmarantz
left a comment
jmarantz
left a comment
There was a problem hiding this comment.
I'm sure this lgtm but just to spread the knowledge of how our infrastructure works, what does this change do?
Member
Author
|
Some Envoy change need depending repo change its WORKSPACE. This PR is to update WORKSPACE here to adhere envoyproxy/envoy#6229. |
Contributor
|
My understanding of what you did is still very superficial, but OK :) |
jmarantz
approved these changes
Apr 9, 2019
htuch
approved these changes
Apr 9, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lizan Zhou lizan@tetrate.io