test: This constructor no longer makes sense in the context of the global test-scoped singleton introduced in https://github.com/envoyproxy/envoy/pull/5708#79
Merged
dnoe merged 1 commit intoenvoyproxy:masterfrom Mar 1, 2019
Conversation
…est-scoped singleton introduced in envoyproxy/envoy#5708 Signed-off-by: Joshua Marantz <jmarantz@google.com>
dnoe
approved these changes
Mar 1, 2019
Contributor
dnoe
left a comment
dnoe
left a comment
There was a problem hiding this comment.
LGTM. If we merge this now, does it mean you can remove the TODOs from envoyproxy/envoy#6139 ?
Contributor
Author
|
I think I need to do something about a sha update, but I forgot whether that's in this repo or the main one. In the meantime the two PRs can be checked in independently, fortunately. |
Contributor
|
This repo automagically updates the submodule SHA with each merged PR in the main (see c12d58f for an example of one of the robo commits that does this). So there's no manual action required. I'm going to merge this one now since they are independent. Then I will review your main repo PR. I think you can now update it to remove the bits required before this was merged. |
This was referenced Mar 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This constructor no longer makes sense in the context of the global test-scoped singleton introduced in envoyproxy/envoy#5708 .