Merged
Conversation
Builds broke as of envoyproxy/envoy@7fa5513 Signed-off-by: Paul Henry <letuboy@gmail.com>
f3nry
force-pushed
the
fenry/foreign-cc-workspace
branch
from
921f6c4 to
2d0f2a5
Compare
htuch
approved these changes
Feb 4, 2019
Member
|
@f3nry we'll still need the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds broke as of envoyproxy/envoy@7fa5513
Original PR in envoy: envoyproxy/envoy#5218
It seems like this won't be needed once the foreign_cc definitions are moved into
envoy_dependencies?