integration: make test use 3-arg base class ctor#69
Merged
mattklein123 merged 1 commit intoenvoyproxy:masterfrom Nov 18, 2018
Merged
integration: make test use 3-arg base class ctor#69mattklein123 merged 1 commit intoenvoyproxy:masterfrom
mattklein123 merged 1 commit intoenvoyproxy:masterfrom
Conversation
Make the constructor of `Echo2IntegrationTest` invoke the 3-arg version of the `BaseIntegrationTest` constructor, in order to allow removing the latter's overloaded constructor. Signed-off-by: Tal Nordan <github@talnordan.com>
talnordan
added a commit
to talnordan/envoy
that referenced
this pull request
Nov 18, 2018
In PR envoyproxy#4512, the 2-arg variant of `BaseIntegrationTest`'s constructor was left temporarily, to allow `echo2_integration_test.cc` to compile. This overloaded constructor can safely be removed once the following PR is merged to the envoyproxy/envoy-filter-example repository: envoyproxy/envoy-filter-example#69 Risk Level: Low Testing: `bazel test //test/...` Docs Changes: N/A Release Notes: N/A Signed-off-by: Tal Nordan <github@talnordan.com>
htuch
pushed a commit
to envoyproxy/envoy
that referenced
this pull request
Nov 19, 2018
In PR #4512, the 2-arg variant of BaseIntegrationTest's constructor was left temporarily, to allow echo2_integration_test.cc to compile. This overloaded constructor can safely be removed once the following PR is merged to the envoyproxy/envoy-filter-example repository: envoyproxy/envoy-filter-example#69 Risk Level: Low Testing: bazel test //test/... Docs Changes: N/A Release Notes: N/A Signed-off-by: Tal Nordan <github@talnordan.com>
fredlas
pushed a commit
to fredlas/envoy
that referenced
this pull request
Mar 5, 2019
In PR envoyproxy#4512, the 2-arg variant of BaseIntegrationTest's constructor was left temporarily, to allow echo2_integration_test.cc to compile. This overloaded constructor can safely be removed once the following PR is merged to the envoyproxy/envoy-filter-example repository: envoyproxy/envoy-filter-example#69 Risk Level: Low Testing: bazel test //test/... Docs Changes: N/A Release Notes: N/A Signed-off-by: Tal Nordan <github@talnordan.com> Signed-off-by: Fred Douglas <fredlas@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the constructor of
Echo2IntegrationTestinvoke the 3-arg versionof the
BaseIntegrationTestconstructor, in order to allow removingthe latter's overloaded constructor.
Signed-off-by: Tal Nordan github@talnordan.com