Bring back the build image tag and fix toolchain config push issues#70
Merged
lizan merged 5 commits intoenvoyproxy:masterfrom Jun 4, 2020
greenhouse-org:bring-back-image-tag
Merged
Bring back the build image tag and fix toolchain config push issues#70lizan merged 5 commits intoenvoyproxy:masterfrom greenhouse-org:bring-back-image-tag
lizan merged 5 commits intoenvoyproxy:masterfrom
greenhouse-org:bring-back-image-tag
Conversation
It is used in the envoy .bazelrc to identify the latest toolchain container image Signed-off-by: Sunjay Bhatia <sbhatia@pivotal.io>
lizan
previously approved these changes
May 28, 2020
Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com> Co-authored-by: Sunjay Bhatia <sunjayb@vmware.com> Signed-off-by: William A Rowe Jr <wrowe@vmware.com> Co-authored-by: William A Rowe Jr <wrowe@vmware.com> Co-authored-by: Sunjay Bhatia <sunjayb@vmware.com>
sunjayBhatia
changed the title
Triggers image rebuild to ensure both linux and Windows toolchain configs are regenerated Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com> Co-authored-by: Sunjay Bhatia <sunjayb@vmware.com> Signed-off-by: William A Rowe Jr <wrowe@vmware.com> Co-authored-by: William A Rowe Jr <wrowe@vmware.com>
lizan
approved these changes
Jun 4, 2020
htuch
pushed a commit
that referenced
this pull request
Jun 4, 2020
[skip ci] Bring back the build image tag and fix toolchain config push issues (#70) It is used in the envoy .bazelrc to identify the latest toolchain container image Signed-off-by: Sunjay Bhatia <sbhatia@pivotal.io> Co-authored-by: William A Rowe Jr <wrowe@vmware.com>
htuch
pushed a commit
that referenced
this pull request
Jun 4, 2020
[skip ci] Regenerate linux toolchains from 78d0e79 [skip ci] Bring back the build image tag and fix toolchain config push issues (#70) It is used in the envoy .bazelrc to identify the latest toolchain container image Signed-off-by: Sunjay Bhatia <sbhatia@pivotal.io> Co-authored-by: William A Rowe Jr <wrowe@vmware.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.