Fix build_container_common.sh for non-x86_64 builds#168
Fix build_container_common.sh for non-x86_64 builds#168phlax merged 1 commit intoenvoyproxy:mainfrom
Conversation
|
Friggin GitHub Web interface... Re-doing the commit for the DCO. |
The Ubuntu build script sources this file, but it would exit instead of return causing some later parts of the build script not to run on non-x86_64 builds. Signed-off-by: Markus Teufelberger <mteufelberger@mgit.at>
MarkusTeufelberger
force-pushed
the
patch-1
branch
from
77319e5 to
7e67ce6
Compare
|
🥳 |
|
cool, ill build this locally, push it to a temp dockerhub repo, and take it for a spin in Envoy CI it will take a while, as its not fast to build - but looks promising - thanks @MarkusTeufelberger for working on this |
phlax
left a comment
phlax
left a comment
There was a problem hiding this comment.
checking through CI - i think you are correct and the fix is good
lets just land it and test directly from published version
thanks @MarkusTeufelberger this fix is really appreciated - and apologies if my pushback was unhelpful
lgtm
|
as a follow up do you want to update the images in Envoy ? we will need to wait for the images to be published and the toolchains to be rebuilt an example PR to do similar can be seen here... |
[skip ci] Fix build_container_common.sh for non-x86_64 builds (#168) The Ubuntu build script sources this file, but it would exit instead of return causing some later parts of the build script not to run on non-x86_64 builds. Signed-off-by: Markus Teufelberger <mteufelberger@mgit.at>
[skip ci] Regenerate linux toolchains from 142e6d5 [skip ci] Fix build_container_common.sh for non-x86_64 builds (#168) The Ubuntu build script sources this file, but it would exit instead of return causing some later parts of the build script not to run on non-x86_64 builds. Signed-off-by: Markus Teufelberger <mteufelberger@mgit.at>
|
Ah sorry, seems like you did that PR then: envoyproxy/envoy#20391 Got a bit late yesterday, I'm glad it helped and hopefully makes envoy packages now also available on ARM64 right from the start! :-) |
2 participants
Th Ubuntu build script sources this file, but it would exit instead of return causing some later parts of the build script not to run on non-x86_64 builds.