-
Notifications
You must be signed in to change notification settings - Fork 67
Added readme on the latest situation about building Envoy on CentOS 7 #165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
1f40fab
Added some readme information on the latest situation about building …
robejfarr dec7749
Fixed DCO for latest Envoy build situation on CentOS 7
robejfarr 06e6f50
Fixed DCO again for latest Envoy build situation on CentOS 7
robejfarr c1bac5f
Added console formatting for latest Envoy build situation on CentOS 7
robejfarr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| You are strongly encouraged to test the produced Envoy binary on CentOS 7 yourselves to ensure that it satisfies your required functionality and operates as expected. | ||
|
|
||
| ## Version 1.21.x | ||
| Envoy version 1.21 onwards cannot currently be compiled on CentOS 7. | ||
|
|
||
| This is due the changes that were made to `tcp_stats.cc` during the 1.21 release and these being incompatible with the linux/tcp.h headers that are included in CentOS 7. | ||
|
|
||
| - `glibc-headers-2.17-317.el7.x86_64.rpm` | ||
| - `kernel-headers-3.10.0-1160.el7.x86_64.rpm` | ||
|
|
||
| ``` | ||
| source/extensions/transport_sockets/tcp_stats/tcp_stats.cc:119:18: error: no member named 'tcpi_data_segs_out' in 'tcp_info'; did you mean 'tcpi_segs_out'? | ||
| if ((tcp_info->tcpi_data_segs_out > last_cx_tx_data_segments_) && | ||
| ^~~~~~~~~~~~~~~~~~ | ||
| tcpi_segs_out | ||
| /usr/include/linux/tcp.h:204:8: note: 'tcpi_segs_out' declared here | ||
| __u32 tcpi_segs_out; /* RFC4898 tcpEStatsPerfSegsOut */ | ||
| ^ | ||
| source/extensions/transport_sockets/tcp_stats/tcp_stats.cc:126:51: error: no member named 'tcpi_data_segs_out' in 'tcp_info'; did you mean 'tcpi_segs_out'? | ||
| const uint32_t data_segs_out_diff = tcp_info->tcpi_data_segs_out - last_cx_tx_data_segments_; | ||
| ^~~~~~~~~~~~~~~~~~ | ||
| tcpi_segs_out | ||
| /usr/include/linux/tcp.h:204:8: note: 'tcpi_segs_out' declared here | ||
| __u32 tcpi_segs_out; /* RFC4898 tcpEStatsPerfSegsOut */ | ||
| ^ | ||
| source/extensions/transport_sockets/tcp_stats/tcp_stats.cc:139:28: error: no member named 'tcpi_data_segs_out' in 'tcp_info'; did you mean 'tcpi_segs_out'? | ||
| tcp_info->tcpi_data_segs_out); | ||
| ^~~~~~~~~~~~~~~~~~ | ||
| tcpi_segs_out | ||
| /usr/include/linux/tcp.h:204:8: note: 'tcpi_segs_out' declared here | ||
| __u32 tcpi_segs_out; /* RFC4898 tcpEStatsPerfSegsOut */ | ||
| ^ | ||
| source/extensions/transport_sockets/tcp_stats/tcp_stats.cc:141:28: error: no member named 'tcpi_data_segs_in' in 'tcp_info'; did you mean 'tcpi_segs_in'? | ||
| tcp_info->tcpi_data_segs_in); | ||
| ^~~~~~~~~~~~~~~~~ | ||
| tcpi_segs_in | ||
| /usr/include/linux/tcp.h:205:8: note: 'tcpi_segs_in' declared here | ||
| __u32 tcpi_segs_in; /* RFC4898 tcpEStatsPerfSegsIn */ | ||
| ^ | ||
| source/extensions/transport_sockets/tcp_stats/tcp_stats.cc:146:26: error: no member named 'tcpi_notsent_bytes' in 'tcp_info' | ||
| tcp_info->tcpi_notsent_bytes); | ||
| ~~~~~~~~ ^ | ||
| ``` | ||
|
|
||
| Further investigation is needed to resolve this problem. Contributions are welcome! For more detail see [here](https://github.com/envoyproxy/envoy-build-tools/pull/154#issuecomment-1033902348). | ||
|
|
||
| ## Version 1.20.x | ||
| Envoy version 1.20 can be compiled on CentOS 7 using `clang and libc++`, but not `clang and libstdc++`, which throws an ambiguous function error. For more detail on this issue and a proposed fix see [here](https://github.com/envoyproxy/envoy/issues/19978). | ||
|
|
||
| ## Version 1.19.x | ||
| Envoy version 1.19 can be built using either `clang and libc++` or `clang and libstdc++` on CentOS 7. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.