Skip to content

python: Remove pyyaml from env#138

Merged
htuch merged 1 commit intoenvoyproxy:mainfrom
phlax:python-remove-yaml
Jun 9, 2021
Merged

python: Remove pyyaml from env#138
htuch merged 1 commit intoenvoyproxy:mainfrom
phlax:python-remove-yaml

Conversation

@phlax
Copy link
Member

@phlax phlax commented Jun 5, 2021

any python environments should install their own pip dependencies rather than having them in the build container

currently, this causes ci to pass tests, where it would fail locally, not using the build image

@phlax phlax requested a review from a team as a code owner June 5, 2021 13:50
Signed-off-by: Ryan Northey <ryan@synca.io>
@phlax phlax force-pushed the python-remove-yaml branch from 7501c1e to ca3e88d Compare June 5, 2021 13:50
@htuch htuch merged commit a17abfa into envoyproxy:main Jun 9, 2021
htuch pushed a commit that referenced this pull request Jun 9, 2021
  [skip ci]
  python: Remove pyyaml from env (#138)

any python environments should install their own pip dependencies rather than having them in the build container

currently, this causes ci to pass tests, where it would fail locally, not using the build image

Signed-off-by: Ryan Northey <ryan@synca.io>
htuch pushed a commit that referenced this pull request Jun 9, 2021
  [skip ci]
  Regenerate linux toolchains from a17abfa

  [skip ci]
  python: Remove pyyaml from env (#138)

any python environments should install their own pip dependencies rather than having them in the build container

currently, this causes ci to pass tests, where it would fail locally, not using the build image

Signed-off-by: Ryan Northey <ryan@synca.io>
phlax added a commit to phlax/envoy-build-tools that referenced this pull request Sep 9, 2021
phlax added a commit to phlax/envoy-build-tools that referenced this pull request Sep 9, 2021
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax added a commit that referenced this pull request Sep 9, 2021
Signed-off-by: Ryan Northey <ryan@synca.io>
htuch pushed a commit that referenced this pull request Sep 9, 2021
  [skip ci]
  revert: #138 readd pyyaml (#146)

Signed-off-by: Ryan Northey <ryan@synca.io>
htuch pushed a commit that referenced this pull request Sep 9, 2021
  [skip ci]
  Regenerate linux toolchains from a4bc794

  [skip ci]
  revert: #138 readd pyyaml (#146)

Signed-off-by: Ryan Northey <ryan@synca.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants