Skip to content

linux: Set locale to en_US.UTF-8#125

Merged
htuch merged 2 commits intoenvoyproxy:mainfrom
phlax:set-locale
Feb 22, 2021
Merged

linux: Set locale to en_US.UTF-8#125
htuch merged 2 commits intoenvoyproxy:mainfrom
phlax:set-locale

Conversation

@phlax
Copy link
Copy Markdown
Member

@phlax phlax commented Feb 21, 2021

Sets locale to utf-8 in ubuntu and centos build images

Make python unicode happy

Also adds a test to ensure that python can handle utf-8 as is required in envoy build environment

@phlax phlax requested a review from a team as a code owner February 21, 2021 18:08
@phlax phlax force-pushed the set-locale branch 6 times, most recently from a130152 to 5632792 Compare February 21, 2021 22:16
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
@phlax phlax changed the title ubuntu: Set locale to en_US.UTF-8 linux: Set locale to en_US.UTF-8 Feb 21, 2021
Copy link
Copy Markdown
Member

@htuch htuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@htuch htuch merged commit d9b1f1c into envoyproxy:main Feb 22, 2021
htuch pushed a commit that referenced this pull request Feb 22, 2021
  [skip ci]
  linux: Set locale to en_US.UTF-8 (#125)

Sets locale to utf-8 in ubuntu and centos build images

Make python unicode happy

Also adds a test to ensure that python can handle utf-8 as is required in envoy build environment

Signed-off-by: Ryan Northey <ryan@synca.io>
htuch pushed a commit that referenced this pull request Feb 22, 2021
  [skip ci]
  Regenerate linux toolchains from d9b1f1c

  [skip ci]
  linux: Set locale to en_US.UTF-8 (#125)

Sets locale to utf-8 in ubuntu and centos build images

Make python unicode happy

Also adds a test to ensure that python can handle utf-8 as is required in envoy build environment

Signed-off-by: Ryan Northey <ryan@synca.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants