Merged
Conversation
This reverts commit f7e4096. Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
sunjayBhatia
force-pushed
the
redo-clang-11
branch
from
548f785 to
7728f34
Compare
Contributor
|
Let's expect to sync this update with #115 |
Contributor
|
/retest I might not have perms to do this, @sunjayBhatia |
Member
Author
|
Looks like the 11.0.0 16.04 binaries are not on the releases page anymore, will need to update to 20.04 |
Contributor
A compromise position would be to bump to 18.04, but I think it's a little late for that. Good call, time to jump to this decade. |
Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
Member
Author
|
cc @lizan this is green if you get a chance to look |
wrowe
reviewed
Jan 25, 2021
Contributor
wrowe
left a comment
wrowe
left a comment
There was a problem hiding this comment.
Can we pick up 11.0.1 windows and mac at the same time and begin keeping these in-sync?
Should we pick back up bazel 4.0.0+3.7.2 in the process?
lizan
previously approved these changes
Jan 25, 2021
Member
|
yeah since bazel 4.0 is released let's pick up it. |
Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
lizan
approved these changes
Jan 25, 2021
htuch
pushed a commit
that referenced
this pull request
Jan 28, 2021
[skip ci] Regenerate linux toolchains from edbec0b [skip ci] Update toolchains to llvm 11.0.1 and bazel 4.0.0 (#119) * Revert revert of "use LLVM 11 (#116)" * Bump to LLVM 11.0.1 on Linux and Windows * Generate bazel 4.0.0 toolchains Authored-by: Sunjay Bhatia <sunjayb@vmware.com> Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reapplies #116 which had to be reverted as it was merged too early
Also bumps Windows LLVM to 11.0.1 and adds Bazel 4.0.0 toolchain generation