stats: add prefix to StatsConfig#604
Merged
mattklein123 merged 6 commits intoenvoyproxy:masterfrom Apr 10, 2018
Merged
Conversation
Signed-off-by: Akhil Thampy <akhil@akhilthampy.com>
mattklein123
reviewed
Apr 4, 2018
| // Envoy will connect to this cluster to flush statistics. | ||
| string tcp_cluster_name = 2; | ||
| } | ||
| string prefix = 3; |
Member
There was a problem hiding this comment.
Please add documentation as well as the not-implemented-hide tag until it's implemented. Thanks!
Signed-off-by: Akhil Thampy <akhil@akhilthampy.com>
mattklein123
reviewed
Apr 4, 2018
| string tcp_cluster_name = 2; | ||
| } | ||
| // [#not-implemented-hide:] Optional custom prefix for StatsdSink. If | ||
| // specified, this will override the default prefix. |
Member
There was a problem hiding this comment.
Can you potentially given an example of how this would be used and what change it will make in the emitted metrics?
Member
There was a problem hiding this comment.
Can you specify what the default is if not specified? "envoy" ?
Signed-off-by: Akhil Thampy <akhil@akhilthampy.com>
Signed-off-by: Akhil Thampy <akhil@akhilthampy.com>
Signed-off-by: Akhil Thampy <akhil@akhilthampy.com>
envoy/config/metrics/v2/stats.proto
Outdated
| // .. code-block:: cpp | ||
| // envoy.test_counter:1|c | ||
| // envoy.test_timer:5|ms | ||
|
|
Member
There was a problem hiding this comment.
Please view the rendered docs. This blank line makes the docs not attach.
Member
Author
There was a problem hiding this comment.
Sorry! This is what it looks like now:
Signed-off-by: Akhil Thampy <akhil@akhilthampy.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add prefix field to StatsdSink proto definition to support custom prefixes.
See envoyproxy/envoy#2897 for more details.
Signed-off-by: Akhil Thampy akhil@akhilthampy.com